Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

delete share permission #143

Merged
merged 1 commit into from
Mar 22, 2024
Merged

delete share permission #143

merged 1 commit into from
Mar 22, 2024

Conversation

ScharfViktor
Copy link
Contributor

Creating a share with share permissions is now not supported. So i changed it for owncloud/ocis#8704

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes necessary for the web acceptance tests? Or doesn't affect the tests?
If not then let's keep them as it is because desktop client tests uses middleware and they maybe affected.

@ScharfViktor
Copy link
Contributor Author

Are these changes necessary for the web acceptance tests? Or doesn't affect the tests?
If not then let's keep them as it is because desktop client tests uses middleware and they maybe affected.

Yes, it's necessary change to allow web tests to work with ocis (without resharing)

client uses an old version of middleware https://github.com/owncloud/client/blob/master/.drone.star#L21C23-L21C62.
If we create a new version for ocis -> I hope it will not affect the client tests

after removing the acceptance tests owncloud/web#10259 we will be able to revert these changes because we will remove the middleware from ocis and web repo.

@saw-jan
Copy link
Member

saw-jan commented Mar 22, 2024

client uses an old version of middleware https://github.com/owncloud/client/blob/master/.drone.star#L21C23-L21C62.
If we create a new version for ocis -> I hope it will not affect the client tests

Yeah 👍 , we pin the versions so unless we release new version and update in client these should be fine.

@ScharfViktor ScharfViktor merged commit ebb6aa2 into main Mar 22, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the deleteSharePermission branch March 22, 2024 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants