Skip to content

Commit

Permalink
Merge pull request #4847 from owncloud/log_app_loading_failure
Browse files Browse the repository at this point in the history
Do not swallow errors when loading extensions
  • Loading branch information
dschmidt authored Mar 25, 2021
2 parents b347b7c + ec17069 commit 084a4ca
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/web-runtime/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const loadApp = async path => {
requirejs(
[path],
app => resolve(app),
() => reject(new Error('failed to load app ' + path))
err => reject(err)
)
)

Expand Down Expand Up @@ -243,7 +243,9 @@ export const exec = async () => {
// please note that we have to go through apps one by one for now, to not break e.g. translations loading (race conditions)
try {
await loadApp(path)
} catch (err) {}
} catch (err) {
console.error('failed to load app ' + path, err)
}
}

// Finalize loading core and apps
Expand Down

0 comments on commit 084a4ca

Please sign in to comment.