Skip to content

Commit

Permalink
Fix acceptance tests for individual share in details view
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalwengerter committed May 9, 2023
1 parent c799132 commit 598844a
Show file tree
Hide file tree
Showing 22 changed files with 162 additions and 119 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingPublicManagement/shareByPublicLink.feature:24](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L24)

### [Uploading folders does not work in files-drop](https://github.com/owncloud/web/issues/2443)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:245](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L245)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:268](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L268)

### [Writing to locked files/folders give only a generic error message](https://github.com/owncloud/web/issues/5741)
- [webUIWebdavLockProtection/upload.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L32)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingExpirationDate/shareWithExpirationDate.feature:21](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExpirationDate/shareWithExpirationDate.feature#L21)

### [Listing shares via ocs API does not show path for parent folders](https://github.com/owncloud/ocis/issues/1231)
- [webUISharingPublicManagement/shareByPublicLink.feature:127](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L127)
- [webUISharingPublicManagement/shareByPublicLink.feature:110](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L110)

### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186)
- [webUIFilesSearch/search.feature:131](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L131)
Expand Down Expand Up @@ -84,7 +84,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingPublicManagement/shareByPublicLink.feature:24](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L24)

### [Uploading folders does not work in files-drop](https://github.com/owncloud/web/issues/2443)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:245](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L245)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:268](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L268)

### [Resources cannot be locked under ocis](https://github.com/owncloud/ocis/issues/1284)
- [webUIWebdavLockProtection/delete.feature:33](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L33)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Feature: deleting files and folders
| | &and#hash |
And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user deletes the following file using the webUI
And the user deletes the following single share using the webUI
| name-parts |
| 'single' |
| "double" quotes |
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/webUIFilesCopy/copy.feature
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Feature: copy files and folders
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user copies file "data.zip" into folder "simple-empty-folder" using the webUI
Then breadcrumb for folder "simple-empty-folder" should be displayed on the webUI
And file "data.zip" should be listed on the webUI
And file "data.zip" should be listed on the webUI as single share
And as "Alice" file "simple-folder/simple-empty-folder/data.zip" should exist in the server
And as "Alice" file "simple-folder/data.zip" should exist in the server

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Feature: move files
And the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user moves file "data.zip" into folder "simple-empty-folder" using the webUI
Then breadcrumb for folder "simple-empty-folder" should be displayed on the webUI
And file "data.zip" should be listed on the webUI
And file "data.zip" should be listed on the webUI as single share
And as "Alice" file "simple-folder/simple-empty-folder/data.zip" should exist in the server
But as "Alice" file "simple-folder/data.zip" should not exist in the server

Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/webUIPreview/mediaPreview.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Feature: display image in preview app on the webUI
Background:
Given user "Alice" has been created with default attributes and without skeleton files in the server

@ocisSmokeTest
Scenario Outline: preview of image files with preview app is possible
@ocisSmokeTest
Scenario Outline: preview of image files with preview app is possible
Given user "Alice" has uploaded file "<image-file>" to "<image-file>" in the server
And user "Alice" has logged in using the webUI
When the user views the file "<image-file>" in the preview app using the webUI
Expand All @@ -28,7 +28,7 @@ Scenario Outline: preview of image files with preview app is possible
And user "Alice" has created a public link with following settings in the server
| path | simple-empty-folder |
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the public views the file "test_video.mp4" in the preview app using the webUI
And the public views the single share file "test_video.mp4" in the preview app using the webUI
Then the file "test_video.mp4" should be displayed in the preview app webUI


Expand All @@ -38,7 +38,7 @@ Scenario Outline: preview of image files with preview app is possible
And user "Alice" has created a public link with following settings in the server
| path | simple-empty-folder |
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the public views the file "testavatar.jpg" in the preview app using the webUI
And the public views the single share file "testavatar.jpg" in the preview app using the webUI
Then the file "testavatar.jpg" should be displayed in the preview app webUI


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ Feature: rename files
And user "Alice" has uploaded file "lorem.txt" to "simple-folder/lorem.txt" in the server
And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user renames file "lorem.txt" to "a-renamed-file.txt" using the webUI
Then file "a-renamed-file.txt" should be listed on the webUI
And the user renames single share "lorem.txt" to "a-renamed-file.txt" using the webUI
Then file "a-renamed-file.txt" should be listed on the webUI as single share
But file "lorem.txt" should not be listed on the webUI
When the user reloads the current page of the webUI
Then file "a-renamed-file.txt" should be listed on the webUI
Then file "a-renamed-file.txt" should be listed on the webUI as single share
But file "lorem.txt" should not be listed on the webUI
And as "Alice" file "simple-folder/a-renamed-file.txt" should exist in the server
And as "Alice" file "simple-folder/lorem.txt" should not exist in the server
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Feature: Create public link shares
| name | Link |
And a link named "Link" should be listed with role "Anyone with the link can view" in the public link list of resource "simple-folder" on the webUI
When the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share

@smokeTest @ocisSmokeTest @issue-ocis-reva-383
Scenario: simple file sharing by public link
Expand All @@ -38,7 +38,7 @@ Feature: Create public link shares
| name | Link |
And a link named "Link" should be listed with role "Anyone with the link can view" in the public link list of resource "lorem.txt" on the webUI
When the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share

@skipOnOC10 @issue-ocis-reva-383
# When this issue is fixed delete this scenario and use the one above
Expand All @@ -54,7 +54,7 @@ Feature: Create public link shares
| permissions | read |
| path | /simple-folder |
When the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share

@skipOnOC10 @issue-ocis-reva-383
# When this issue is fixed delete this scenario and use the one above
Expand All @@ -69,7 +69,7 @@ Feature: Create public link shares
| permissions | read |
| path | /lorem.txt |
When the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share

@issue-ocis-reva-389
Scenario: user shares a public link with folder longer than 64 chars and shorter link name
Expand All @@ -79,7 +79,7 @@ Feature: Create public link shares
And user "Alice" has logged in using the webUI
When the user creates a new public link for folder "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog" using the webUI
And the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share


Scenario: share two files with same name but different paths by public link
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Feature: Edit public link shares
| password | pass123 |
When the user renames the public link named "Public-link" of folder "simple-folder" to "simple-folder Share"
And the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share


Scenario: user edits the password of an already existing public link
Expand All @@ -83,7 +83,7 @@ Feature: Edit public link shares
And user "Alice" has logged in using the webUI
When the user tries to edit the public link named "Public-link" of folder "simple-folder" changing the password to "qwertyui"
And the public uses the webUI to access the last public link created by user "Alice" with password "qwertyui" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share

@issue-3830
Scenario: user edits the password of an already existing public link and tries to access with old password
Expand All @@ -110,8 +110,8 @@ Feature: Edit public link shares
And user "Alice" has logged in using the webUI
When the user tries to edit the public link named "Public-link" of folder "simple-folder" changing the role to "Viewer"
And the public uses the webUI to access the last public link created by user "Alice" in a new session
Then file "lorem.txt" should be listed on the webUI
And it should not be possible to delete file "lorem.txt" using the webUI
Then file "lorem.txt" should be listed on the webUI as single share
And it should not be possible to delete file "lorem.txt" as single share using the webUI

@issue-ocis-reva-292 @disablePreviews
Scenario: user edits the permission of an already existing public link from read to read-write
Expand All @@ -128,7 +128,9 @@ Feature: Edit public link shares
And the user deletes the following elements using the webUI
| name |
| simple-empty-folder |
| lorem.txt |
And the user deletes the following single share using the webUI
| name-parts |
| lorem.txt |
Then the deleted elements should not be listed on the webUI
And the deleted elements should not be listed on the webUI after a page reload

Expand Down Expand Up @@ -167,4 +169,4 @@ Feature: Edit public link shares
And user "Alice" has logged in using the webUI
When the user tries to edit the public link named "Public-link" of folder "lorem.txt" adding a password "pass123"
And the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: Access public link shares by public
Given user "Alice" has created file "simple-folder/lorem.txt" in the server
And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123" in the server
When the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
Then file "lorem.txt" should be listed on the webUI
Then file "lorem.txt" should be listed on the webUI as single share


Scenario: public should not be able to access a public link with wrong password
Expand Down
Loading

0 comments on commit 598844a

Please sign in to comment.