added changelog fixed linting

owncloud · Jul 30, 2021 · a35216c · a35216c
1 parent 024a453
commit a35216c
Show file tree

Hide file tree

Showing 16 changed files with 35 additions and 28 deletions.
diff --git a/changelog/unreleased/enhancement-table-role-presentation-for-version-table b/changelog/unreleased/enhancement-table-role-presentation-for-version-table
@@ -0,0 +1,7 @@
+Enhancement: Add table role to version table
+
+In order to achieve better a11y we needed to adjust the role of the
+version table.
+
+https://github.com/owncloud/web/issues/5381
+https://github.com/owncloud/web/pull/5567
diff --git a/packages/web-app-draw-io/src/App.vue b/packages/web-app-draw-io/src/App.vue
@@ -2,7 +2,7 @@
   <main>
     <oc-spinner
       v-if="loading"
-      :aria-label="this.$gettext('Loading media')"
+      :aria-label="$gettext('Loading media')"
       class="uk-position-center"
       size="xlarge"
     />
@@ -51,7 +51,7 @@ export default {
     this.checkPermissions()
     window.addEventListener('message', event => {
       if (event.data.length > 0) {
-        var payload = JSON.parse(event.data)
+        const payload = JSON.parse(event.data)
         switch (payload.event) {
           case 'init':
             this.fileExtension === 'vsdx' ? this.importVisio() : this.load()
@@ -137,8 +137,8 @@ export default {
           return resp.arrayBuffer()
         })
         .then(arrayBuffer => {
-          var blob = new Blob([arrayBuffer], { type: 'application/vnd.visio' })
-          var reader = new FileReader()
+          const blob = new Blob([arrayBuffer], { type: 'application/vnd.visio' })
+          const reader = new FileReader()
           reader.onloadend = () => {
             this.$refs.drawIoEditor.contentWindow.postMessage(
               JSON.stringify({

diff --git a/packages/web-app-files/src/components/Collaborators/NewCollaborator.vue b/packages/web-app-files/src/components/Collaborators/NewCollaborator.vue
@@ -14,7 +14,7 @@
       @input="$_ocCollaborators_selectAutocompleteResult"
       @update:input="$_onAutocompleteInput"
     >
-      <template v-slot:item="{ item }">
+      <template #item="{ item }">
         <autocomplete-item :item="item" />
       </template>
     </oc-autocomplete>

diff --git a/packages/web-app-files/src/views/Favorites.vue b/packages/web-app-files/src/views/Favorites.vue
@@ -22,7 +22,7 @@
         @showDetails="setHighlightedFile"
         @fileClick="$_fileActions_triggerDefaultAction"
       >
-        <template v-slot:quickActions="props">
+        <template #quickActions="props">
           <quick-actions class="oc-visible@s" :item="props.resource" :actions="app.quickActions" />
         </template>
         <template #footer>

diff --git a/packages/web-app-files/src/views/Personal.vue b/packages/web-app-files/src/views/Personal.vue
@@ -9,10 +9,10 @@
         class="files-empty"
         icon="folder"
       >
-        <template v-slot:message>
+        <template #message>
           <span v-translate>There are no resources in this folder</span>
         </template>
-        <template v-slot:callToAction>
+        <template #callToAction>
           <span v-translate>Drag files and folders here or use the "+ New" button to upload</span>
         </template>
       </no-content-message>
@@ -30,7 +30,7 @@
         @showDetails="setHighlightedFile"
         @fileClick="$_fileActions_triggerDefaultAction"
       >
-        <template v-slot:quickActions="{ resource }">
+        <template #quickActions="{ resource }">
           <quick-actions
             :class="resource.preview"
             class="oc-visible@s"

diff --git a/packages/web-app-files/src/views/PublicFiles.vue b/packages/web-app-files/src/views/PublicFiles.vue
@@ -9,10 +9,10 @@
         class="files-empty"
         icon="folder"
       >
-        <template v-slot:message>
+        <template #message>
           <span v-translate>There are no resources in this folder</span>
         </template>
-        <template v-if="currentFolder.canCreate()" v-slot:callToAction>
+        <template v-if="currentFolder.canCreate()" #callToAction>
           <span v-translate>Drag files and folders here or use the "+ New" button to upload</span>
         </template>
       </no-content-message>

diff --git a/packages/web-app-files/src/views/SharedWithMe.vue b/packages/web-app-files/src/views/SharedWithMe.vue
@@ -28,7 +28,7 @@
         @showDetails="setHighlightedFile"
         @fileClick="$_fileActions_triggerDefaultAction"
       >
-        <template v-slot:status="{ resource }">
+        <template #status="{ resource }">
           <div
             :key="resource.id + resource.status"
             class="uk-text-nowrap uk-flex uk-flex-middle uk-flex-right"

diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue
@@ -31,10 +31,10 @@
             :fixed="isSidebarFixed"
             @close="toggleAppNavigationVisibility"
           >
-            <template v-if="sidebar.mainContentComponent" v-slot:mainContent>
+            <template v-if="sidebar.mainContentComponent" #mainContent>
               <component :is="sidebar.mainContentComponent" />
             </template>
-            <template v-if="sidebar.sidebarFooterContentComponent" v-slot:footer>
+            <template v-if="sidebar.sidebarFooterContentComponent" #footer>
               <component :is="sidebar.sidebarFooterContentComponent" />
             </template>
           </oc-sidebar>

diff --git a/packages/web-runtime/src/index.js b/packages/web-runtime/src/index.js
@@ -72,9 +72,9 @@ Vue.use(VueMeta, {
 Vue.use(ChunkedUpload)
 Vue.use(Vue2TouchEvents)
 
-Vue.component('drag', Drag)
-Vue.component('drop', Drop)
-Vue.component('avatar-image', Avatar)
+Vue.component('Drag', Drag)
+Vue.component('Drop', Drop)
+Vue.component('AvatarImage', Avatar)
 
 Vue.mixin(focusMixin)
 Vue.mixin(lifecycleMixin)

diff --git a/packages/web-runtime/src/plugins/upload.js b/packages/web-runtime/src/plugins/upload.js
@@ -13,7 +13,7 @@ export default {
           return new Promise((resolve, reject) => {
             const headers = this.$client.helpers.buildHeaders()
             delete headers['OCS-APIREQUEST']
-            var mtime = null
+            let mtime = null
             if (file.lastModifiedDate) {
               mtime = file.lastModifiedDate.getTime() / 1000
             }

diff --git a/packages/web-runtime/src/plugins/web.js b/packages/web-runtime/src/plugins/web.js
@@ -89,7 +89,7 @@ export default {
           if (!path) {
             return path
           }
-          var parts = path.split('/').map(part => encodeURIComponent(part))
+          const parts = path.split('/').map(part => encodeURIComponent(part))
           return parts.join('/')
         },
         triggerDownload(url, name) {

diff --git a/tests/acceptance/customCommands/angryClick.js b/tests/acceptance/customCommands/angryClick.js
@@ -5,7 +5,7 @@
 // Try dismissing lightboxes/overlays by clicking on the body tag,
 // then click again.
 exports.command = function angryClick(selector, callback) {
-  var self = this
+  const self = this
   return this.click(selector, function(result) {
     if (result.status === 0) {
       // click succeeded, handle callback

diff --git a/tests/acceptance/customCommands/waitForAjaxCallsToStartAndFinish.js b/tests/acceptance/customCommands/waitForAjaxCallsToStartAndFinish.js
@@ -1,8 +1,8 @@
-var numAjaxRequestsStart = 0
-var start = 0
-var end = 0
+let numAjaxRequestsStart = 0
+let start = 0
+let end = 0
 const sleepWhenNoNewAjaxCallsStarted = function(result) {
-  var currentTime = Date.now()
+  const currentTime = Date.now()
   if (result.value <= numAjaxRequestsStart && currentTime < end) {
     this.pause(this.globals.waitForConditionPollInterval)
     checkSumStartedAjaxRequests(this)

diff --git a/tests/acceptance/helpers/ldapHelper.js b/tests/acceptance/helpers/ldapHelper.js
@@ -200,7 +200,7 @@ exports.addUserToGroup = function(client, user, group) {
     client.search(groupCn, { attributes: [] }, (err, res) => {
       if (err) reject(err)
       res.on('searchEntry', function(entry) {
-        var memberUid
+        let memberUid
         if (entry.object.memberUid) {
           if (
             entry.object.memberUid === user ||

diff --git a/tests/acceptance/helpers/sharingHelper.js b/tests/acceptance/helpers/sharingHelper.js
@@ -36,7 +36,7 @@ module.exports = {
     humanReadablePermissions = humanReadablePermissions.map(function(s) {
       return String.prototype.trim.apply(s)
     })
-    for (var i = 0; i < humanReadablePermissions.length; i++) {
+    for (let i = 0; i < humanReadablePermissions.length; i++) {
       if (humanReadablePermissions[i] in this.PERMISSION_TYPES) {
         permissionBitMask = permissionBitMask + this.PERMISSION_TYPES[humanReadablePermissions[i]]
       } else {

diff --git a/tests/acceptance/stepDefinitions/sharingContext.js b/tests/acceptance/stepDefinitions/sharingContext.js
@@ -794,8 +794,8 @@ Then(
       .then(itemsList => {
         itemsList.forEach(item => {
           const displayedName = item.split('\n')[0]
-          var found = false
-          for (var userId in userSettings.getCreatedUsers()) {
+          let found = false
+          for (const userId in userSettings.getCreatedUsers()) {
             const userDisplayName = userSettings.getDisplayNameForUser(userId)
             if (
               userDisplayName === displayedName &&