Skip to content

Commit

Permalink
Fix page titles and quotation marks
Browse files Browse the repository at this point in the history
  • Loading branch information
kulmann committed Aug 24, 2021
1 parent 34ba09a commit dac2db7
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
appearance="raw"
:to="homeRoute"
>
<translate>Go to »All files«</translate>
<translate>Go to "All files"</translate>
</oc-button>
<oc-button
v-if="showPublicLinkButton"
Expand Down
3 changes: 2 additions & 1 deletion packages/web-app-files/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ const routes = [
},
meta: {
verbose: true,
auth: false
auth: false,
title: $gettext('Pick target folder')
}
},
{
Expand Down
12 changes: 10 additions & 2 deletions packages/web-app-files/src/views/LocationPicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,16 @@ export default {
title() {
const translated =
this.currentAction === batchActions.move
? this.$gettext('Move into »%{ target }«')
: this.$gettext('Copy into »%{ target }«')
? this.$ngettext(
'Move selected item into "%{ target }"',
'Move selected items into "%{ target }"',
this.resourcesCount
)
: this.$ngettext(
'Copy selected item into "%{ target }"',
'Copy selected items into "%{ target }"',
this.resourcesCount
)
const target = basename(this.target) || this.$gettext('All files')
return this.$gettextInterpolate(translated, { target })
},
Expand Down
2 changes: 1 addition & 1 deletion packages/web-runtime/src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export default {
announceRouteChange(route) {
const pageTitle = this.extractPageTitleFromRoute(route, false)
const translated = this.$gettext('Navigated to %{ pageTitle }')
const translated = this.$gettext('Navigated to page "%{ pageTitle }"')
this.announcement = this.$gettextInterpolate(translated, { pageTitle })
},
Expand Down

0 comments on commit dac2db7

Please sign in to comment.