Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the options.sidebar.shares.showAllOnLoad config option #11212

Closed
kulmann opened this issue Jul 18, 2024 · 0 comments · Fixed by #11251
Closed

Get rid of the options.sidebar.shares.showAllOnLoad config option #11212

kulmann opened this issue Jul 18, 2024 · 0 comments · Fixed by #11251
Assignees
@AlexAndBear
Labels
Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Jul 18, 2024

Describe the bug

Config optioon options.sidebar.shares.showAllOnLoad only exists to make life easier in CI/e2e tests. The real world behaviour is and should be, that only the first 3 shares are shown and then a Show all button is being rendered if there are more shares.

Adapt the e2e tests to make the click on Show all if needed, then delete the config option.
@kulmann kulmann added the Type:Bug Something isn't working label Jul 18, 2024
@AlexAndBear AlexAndBear self-assigned this Jul 18, 2024
@AlexAndBear AlexAndBear mentioned this issue Jul 22, 2024
Merged
8 tasks
AlexAndBear added a commit that referenced this issue Jul 22, 2024
@AlexAndBear
Merge pull request #11251 from /issues/11212
7cbcc9b 
Purge config option options.sidebar.shares.showAllOnLoad
ownclouders pushed a commit that referenced this issue Jul 22, 2024
@AlexAndBear
Merge pull request #11251 from /issues/11212
fddbd9e 
Purge config option options.sidebar.shares.showAllOnLoad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAndBear AlexAndBear

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Purge config option options.sidebar.shares.showAllOnLoad owncloud/web
2 participants
@kulmann @AlexAndBear