-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI fail when warnings in console #2728
Comments
Context: we had ODS updates recently that introduced new required attributes but CI still passed. |
I found this API to access log entries: https://stackoverflow.com/a/53780970 |
we could have a check in the AfterScenario hook |
I managed to come up with something that works: #2729 |
We should take another look at this after #5194 got merged |
Closing as not relevant anymore. We usually check the console for warnings&errors when doing PR reviews and releases Also @ScharfViktor maybe take note of this idea for improving smoke tests in the future. Not pressing from my POV, though |
We should trigger a CI failure whenever we detect warnings in the browser console at the end of any successful test.
If this is too complicated to do technically, then at least add scenarios for the main pages like the files app, public link page and files drop.
This way we can catch these earlier as they could be signs of regressions.
@individual-it @DeepDiver1975 @LukasHirt
The text was updated successfully, but these errors were encountered: