-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch console errors in CI #2729
Conversation
|
@PVince81, there's conflict as I just refactored |
b3caa4c
to
6d1eab9
Compare
6d1eab9
to
cfaa91a
Compare
cfaa91a
to
fd93b55
Compare
Rebased PR after #2726 has been merged. |
the missing avatar seems to be an issue: |
Raised #2977 for the avatar errors |
fd93b55
to
6be16d1
Compare
Rebased and adjusted as follows:
|
everything has changed since last time
6be16d1
to
c45a442
Compare
c45a442
to
66396f0
Compare
if we still need this, this will need to be redone |
Description
Catch console errors in CI at the end of every test.
If any errors are found, the test will fail and the offending messages are printed out.
Related Issue
Fixes #2728
Motivation and Context
How Has This Been Tested?
Manual test with master, since we have console errors there already...
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: