Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.4.1.2 - Name, role, value available #5397

Open
tbsbdr opened this issue Jun 25, 2021 · 7 comments
Open

[a11y] 9.4.1.2 - Name, role, value available #5397

tbsbdr opened this issue Jun 25, 2021 · 7 comments
Assignees

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 25, 2021


General notes

  • All pages: for the elements of the user menue (Liste mit "Profil", "Einstellungen", etc.) ARIA role="tooltip" was used. In this case this is not correct as it has an other purpose - "A contextual popup that displays a description for an element.". The roles should be removed.
    Also using the aria-describedby attribute on the button "Benutzermenü" in the expanded sub menue is not necessary.
  • Pages 1 to 3 / modal dialogues: using aria-labelledby ( aria-labelledby="ocmodal-title" ) is not allowed on div und span elements as screenreader won’t handle the attribute reliable. An accessible sample can be found here: https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.html.
  • Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons.

Status: rather fulfilled

  • Page 4 (Konto)
    See general notes

Status: partly fulfilled

  • Page 1 (Alle Dateien)
    When copying or moving an element (Folder or file) a new page is opened.
    On opening (because of using aria-live="polite“) the text "Zur Seite files- location-picker navigiert" is read by screenreaders. This text contains an English variable and is not informative. A better solution would be to remove aria-live="polite" and move the keyboard focus with tabindex="-1" on the h1-heading on page load.
    See general notes

  • Page 2 (Mit anderen geteilten Dateien)
    See general notes

  • Page 3 (Gelöschte Dateien)
    See general notes

@lookacat
Copy link
Contributor

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Jul 26, 2021

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

Should be possible (according to https://kabbouchi.github.io/tippyjs-v4-docs/all-options/, search for "role" on this page) in OcTooltip.js in the design system, yet haven't tried it myself

@lookacat
Copy link
Contributor

@pascalwengerter oh thx didnt see that

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

role from tippy removed in owncloud/owncloud-design-system@2ef8eaa

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

aria-labelledby moved to correct element in modal in ODS commit owncloud/owncloud-design-system@2def914

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

page title for location picker is fixed in dac2db7 but needs german translations (will do that in bulk later)

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

We won't fix the Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons. and keep it as a button instead, since it's no violation and would need major refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants