Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove owncloud-sdk and re-implement it in web-client #9709

Closed
6 tasks done
JammingBen opened this issue Sep 19, 2023 · 1 comment · Fixed by #10679
Closed
6 tasks done

Remove owncloud-sdk and re-implement it in web-client #9709

JammingBen opened this issue Sep 19, 2023 · 1 comment · Fixed by #10679
Assignees
Labels
Category:Technical Technical ehancements

Comments

@JammingBen
Copy link
Collaborator

JammingBen commented Sep 19, 2023

The owncloud-sdk is quite old, does not fullfil our code standards and is hard to maintain because of the linking process. The latter makes future adjustments very time consuming, especially since we're planning to switch to id-based WebDAV requests.

Hence we figured it makes sense to remove the owncloud-sdk and implement its logic in our web-client package.

To-Do's

  • Make sure Web uses the provided webdav abstraction instead of the sdk directly for webdav requests
  • Port all WebDAV requests to a new abstraction in web-client
  • Port OCS requests to a new abstraction in web-client (expect for the sharing stuff, which will be replace via sharing NG)
  • Check if settings API needs to be ported -> no needed
  • What about signUrl logic? -> refactor: move url signing to web-client package #10621
  • Add proper (unit-) tests for the new code
@JammingBen JammingBen added the Category:Technical Technical ehancements label Sep 19, 2023
@kulmann
Copy link
Member

kulmann commented Sep 19, 2023

Hopefully pays off now that @dschmidt and myself already built an abstraction layer for webdav in web-client. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Technical Technical ehancements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants