Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle favorites via our webdav implementation instead of sdk #10613

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 14, 2024

Description

Handle favorites (listing and marking) via our webdav implementation instead of using the SDK. Also adds the possibility to do a proppatch and to use filterRules via a report request via our webdav implementation.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Mar 14, 2024
Copy link

update-docs bot commented Mar 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the add-favorites-to-webdav-implementation branch from b8e5167 to 43a0538 Compare March 14, 2024 14:12
@JammingBen JammingBen marked this pull request as ready for review March 14, 2024 15:33
@JammingBen JammingBen force-pushed the add-favorites-to-webdav-implementation branch from 43a0538 to 56b0a2c Compare March 19, 2024 10:16
Copy link

sonarcloud bot commented Mar 19, 2024

@JammingBen JammingBen requested a review from kulmann March 19, 2024 10:56
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen merged commit d291332 into master Mar 19, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-favorites-to-webdav-implementation branch March 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants