feat: show modal when creating links in embed mode #10076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
improve-embed-mode-link-sharing
branch
4 times, most recently
from
202876a
to
fa0cf34
Compare
This was referenced Nov 28, 2023
JammingBen
force-pushed
the
improve-embed-mode-link-sharing
branch
4 times, most recently
from
67bb0fe
to
c7c6e85
Compare
JammingBen
force-pushed
the
improve-embed-mode-link-sharing
branch
3 times, most recently
from
95ced20
to
161c04d
Compare
JammingBen
requested review from
dschmidt,
lookacat,
kulmann and
AlexAndBear
Adds a modal that pops up after clicking "Share links" in embed mode where the user can specify the props of the link(s) they want to create: password, role, name. It also changes the behavior so there will be always new links created instead of re-using existing links.
JammingBen
force-pushed
the
improve-embed-mode-link-sharing
branch
from
161c04d
to
62b68ed
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Dec 5, 2023
| if (failed.length) { | ||
| failed.forEach((error) => { | ||
| console.error(error) | ||
| store.dispatch('showErrorMessage', { |
There was a problem hiding this comment.
a bit weird to have a generic, pluralized message for each and every error individually. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a modal that pops up after clicking "Share links" in embed mode where the user can specify the props of the link(s) they want to create: password, role, name. It also changes the behavior so there will be always new links created instead of re-using existing links.
A few things had to be refactored course of this.
LinkRoleDropdown(refactor: move link role dropdown to a re-usable component #10079) (actually this was not needed in the end, but doesn't hurt)getExpirationRules(refactor: move link expiration rules to a helper method #10080)files_sharing.public.password.enforced_for(refactor: create composable for password enforcement capability #10081)Minor other changes:
Create a new foldertoNew folderOcRadiocomponent, added types for themodelValueRelated Issue
How to test
embed=trueScreenshot
Types of changes