Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiles view preview images in general (zooming issue) and files list thumbnails in spaces #10149

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Dec 12, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

Copy link

update-docs bot commented Dec 12, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Fix tiles view thumbnails Fix tiles view preview images in general (zooming issue) and files list thumbnails in spaces Dec 12, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but looks good to me so far 👍

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@AlexAndBear AlexAndBear enabled auto-merge (squash) December 12, 2023 15:51
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
48.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 961d083 into master Dec 12, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-tiles-view branch December 12, 2023 16:17
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
…st thumbnails in spaces (#10149)

* Fix tiles view thumbnails

* Fix error, while imageContent is loading its showing an error image shortly

* Use fit processor on space header

* Fix bug while loading spaces without images

* Fix for space details

* Fix upload doesnt reload image

* Fix unit tests

* Add changelog item

* Update packages/web-app-files/src/views/spaces/Projects.vue

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>

---------

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] distorted/clinched space thumbnails in list view Spaces overview: Thumbnail image is zoomed in
3 participants