Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modal implementation #10212

Merged
merged 6 commits into from
Dec 22, 2023
Merged

refactor: modal implementation #10212

merged 6 commits into from
Dec 22, 2023

Commits on Dec 20, 2023

  1. refactor: modal implementation

    @JammingBen
    JammingBen committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b413395 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. refactor: rename registerModal to dispatchModal

    @JammingBen
    JammingBen committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5101319 View commit details
    Browse the repository at this point in the history

  2. refactor: remove explicit active property from modals

    @JammingBen
    JammingBen committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0c15583 View commit details
    Browse the repository at this point in the history

  3. style: run linter

    @JammingBen
    JammingBen committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f03b08c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. fix: importer modal now rendering content

    @JammingBen
    JammingBen committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    79a3f72 View commit details
    Browse the repository at this point in the history

  2. test: align modal.ts test file name with actual file name

    @JammingBen
    JammingBen committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    9df16e8 View commit details
    Browse the repository at this point in the history