Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save file in app when dowload gets triggered, so the file eq the current state #11174

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Save file in app when dowload gets triggered, so the file eq the current state #11174

merged 4 commits into from
Jul 11, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 10, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Jul 10, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann July 10, 2024 22:08
dschmidt
dschmidt approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@AlexAndBear AlexAndBear enabled auto-merge (squash) July 11, 2024 11:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 0684173 into master Jul 11, 2024
3 checks passed
@JammingBen JammingBen mentioned this pull request Jul 29, 2024
Merged
@micbar micbar mentioned this pull request Jul 30, 2024
Closed
20 tasks
@kulmann kulmann deleted the issues/11072 branch September 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

download in editor context menu downloads last saved state (what about dirty state?)
3 participants
@AlexAndBear @dschmidt @JammingBen