Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make show more button toggle text in space member view reactive #11263

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Make show more button toggle text in space member view reactive #11263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
337c5f0
Make show more button toggle text in space member view reactive
AlexAndBear Jul 24, 2024
90eed90
Add changelog item
AlexAndBear Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/bugfix-show-more-toggle-text-in-space-members-view-not-reactive
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Show more toggle in space members view not reactive

We've fixed a bug where the toggle to show more members in the space members view was not reactive.
Clicking the toggle in the sidebar will now correctly display “Show More” or “Show Less” as intended.

https://github.com/owncloud/web/pull/11263
https://github.com/owncloud/web/issues/11261
6 changes: 5 additions & 1 deletion packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
<oc-button
appearance="raw"
@click="toggleMemberListCollapsed"
v-text="collapseButtonTitle"
v-text="collapseMemberButtonTitle"
/>
</div>
</template>
Expand Down Expand Up @@ -222,6 +222,10 @@ export default defineComponent({
return this.sharesListCollapsed ? this.$gettext('Show more') : this.$gettext('Show less')
},

collapseMemberButtonTitle() {
return this.memberListCollapsed ? this.$gettext('Show more') : this.$gettext('Show less')
},

hasSharees() {
return this.displayCollaborators.length > 0
},
Expand Down