Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase padding on create link password field, change clipboard link #11324

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Aug 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Increase margin on create link password field, change clipboard link Increase padding on create link password field, change clipboard link Aug 5, 2024
@tbsbdr
Copy link
Contributor

tbsbdr commented Aug 5, 2024

super, thanks!

link: succeeded[0].value.webUrl,
password
},
true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie, passwords were html escaped 🤯

Copy link

sonarcloud bot commented Aug 5, 2024

@AlexAndBear AlexAndBear merged commit 49cab88 into master Aug 5, 2024
3 checks passed
@AlexAndBear AlexAndBear self-assigned this Aug 8, 2024
@kulmann kulmann deleted the link-modal-followup branch September 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants