Convert buttons in files list to urls, align in context menu #11329
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
force-pushed
the
open-in-new-tab
branch
2 times, most recently
from
d1c74d3
to
c8df178
Compare
packages/web-pkg/src/composables/actions/spaces/useSpaceActionsEditReadmeContent.ts
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/FilesList/ResourceDetails.vue
Outdated
Show resolved
Hide resolved
| const openInNewTabHint = computed(() => { | ||
| return $gettext( | ||
| 'Hold %{key} and click to open in new tab', | ||
| { key: unref(isMacOs) ? '⌘' : 'ctrl' }, |
There was a problem hiding this comment.
How to localize the strg/Ctrl key
AlexAndBear
force-pushed
the
open-in-new-tab
branch
2 times, most recently
from
bd23fc6
to
fc88a61
Compare
AlexAndBear
changed the title
| @@ -139,6 +143,7 @@ export default defineComponent({ | |||
| const { getFileContents, getFileInfo } = clientService.webdav | |||
| const previewService = usePreviewService() | |||
| const resourcesStore = useResourcesStore() | |||
| const { getDefaultAction } = useFileActions() | |||
| const { actions: editReadmeContentActions } = useSpaceActionsEditReadmeContent() | |||
There was a problem hiding this comment.
I guess this can be removed then.
I'm wondering in general, now that this is an a element, wouldn't it make sense in the context menu as well? Or is there a reason it should differ?
There was a problem hiding this comment.
Would make sense, was there and encountered issues. In the context menu action, we care about creating the .space folder and the readme file if not exist beforehand.
As soon those files are protected from being deleted:
owncloud/ocis#8719
We might be able to convert the button in the context menu as well to an a tag
… if we dont have a space eg in the shared with me view
AlexAndBear
force-pushed
the
open-in-new-tab
branch
from
8a8aa46
to
d064fc8
Compare
|
* Convert app action buttons to links
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: