Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark external user shares in sidebar #11394

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Aug 23, 2024

Description

Marks external user shares in the sidebar so they can be distinguished from internal shares.

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Aug 23, 2024
Copy link

update-docs bot commented Aug 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Marks external user shares in the sidebar so they can be distinguished from internal shares.
Copy link

sonarcloud bot commented Aug 26, 2024

@JammingBen JammingBen marked this pull request as ready for review August 26, 2024 06:03
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With most recent ocis the external shares are not displayed with the globe icon for me but with the avatar-style-initials. Does this work for you?

@JammingBen
Copy link
Collaborator Author

JammingBen commented Aug 26, 2024

With most recent ocis the external shares are not displayed with the globe icon for me but with the avatar-style-initials. Does this work for you?

Works fine for me, yes. Does the server respond correctly? The response of the .../permissions endpoint should have a @libre.graph.userType property inside value > grantedToV2 > user.

@kulmann
Copy link
Member

kulmann commented Aug 26, 2024

With most recent ocis the external shares are not displayed with the globe icon for me but with the avatar-style-initials. Does this work for you?

Works fine for me, yes. Does the server respond correctly? The response of the .../permissions endpoint should have a @libre.graph.userType property inside value > grantedToV2 > user.

As discussed in zoom: issue was that I tried to do this with einstein, which doesn't have unique uuids across instances.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤩

@JammingBen JammingBen merged commit f5ba349 into master Aug 26, 2024
3 checks passed
@kulmann kulmann deleted the feat/mark-federated-shares branch September 5, 2024 19:47
@micbar micbar mentioned this pull request Sep 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants