Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logout with OIDC #4211

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fix logout with OIDC #4211

merged 1 commit into from
Oct 21, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Oct 20, 2020

Description

Open signout URL directly.

Related Issue

@LukasHirt LukasHirt self-assigned this Oct 20, 2020
@update-docs
Copy link

update-docs bot commented Oct 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt marked this pull request as ready for review October 20, 2020 12:58
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just for the record: with this change we log out the user from the IdP. If it's a company wide IdP and we are just one application, this might be annoying. A better solution might be to unload the user and the user to click some "Login" button (without needing to enter credentials) when the user is still logged in at the IdP. CC @pmaier1

@LukasHirt LukasHirt merged commit 2d4023e into master Oct 21, 2020
@LukasHirt LukasHirt deleted the bugfix/logout branch October 21, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logout sometimes does not work
2 participants