Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not found error page #4411

Merged
merged 14 commits into from
Dec 4, 2020
Merged

Not found error page #4411

merged 14 commits into from
Dec 4, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 2, 2020 •
edited
Loading

Description

This PR brings a dedicated not found page for the files app. It can be displayed by navigating into a folder and then deleting it in another tab. This is true for a) the All files page and b) public links.
The not found page will show a link to recover from the page. For All files it's offering to go back to the home of the All files page and for public links it is offering to reload the root of the public link.

As a bonus, this PR brings a new options.homeFolder option for the config.json file. It can be used to provide a default path for the All files page. The user is not jailed in that path, full breadcrumbs are still usable.

As one more bonus, this PR now makes sure that we also show the breadcrumbs for invalid paths. If you navigate to paths that are still not valid, the same not found page will appear, which is a valid and possibly helpful state.

Related Issue

Motivation and Context

UX improvement

How Has This Been Tested?

  • drone

Screenshots (if appropriate):

Screenshot 2020-12-03 at 16 11 22

Screenshot 2020-12-03 at 16 11 46

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs

This comment has been minimized.

Sign in to view
@kulmann kulmann marked this pull request as ready for review December 3, 2020 15:09
@kulmann kulmann self-assigned this Dec 3, 2020
@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Dec 3, 2020
LukasHirt
LukasHirt approved these changes Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, otherwise amazing! 🚀

tests/acceptance/stepDefinitions/generalContext.js Outdated Show resolved Hide resolved
changelog/unreleased/resource-not-found-error-page Outdated Show resolved Hide resolved
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Dec 4, 2020
Closed
@kulmann kulmann merged commit abea5d3 into master Dec 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the not-found-error-page branch December 4, 2020 09:25
ownclouders pushed a commit that referenced this pull request Dec 4, 2020
@kulmann
commit abea5d3
fc5e70c 
Merge: 1dc2b24 4b9c492
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Fri Dec 4 10:25:33 2020 +0100

    Merge pull request #4411 from owncloud/not-found-error-page

    Not found error page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ocis-web] Recover from "not found" directory Make home path configurable
2 participants
@kulmann @LukasHirt