Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring oc-table-files component and refactor views #4627

Merged
merged 216 commits into from
Mar 25, 2021
Merged

Bring oc-table-files component and refactor views #4627

merged 216 commits into from
Mar 25, 2021

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jan 19, 2021 •
edited by kulmann
Loading

Open tasks in this PR

  • Fix status indicators (access store in the helper file)
  • Fix layout of the app (moving away from overflows)
  • Update ODS with fixes for Resource component
  • Tests (check existing acceptance tests, possibly rewrite some to unit tests)
  • Fix location picker
  • Fix file actions
  • Fix error about unknown routes
  • Adjust table header position depending on the view and available content of app header
  • Fix batch actions
  • Display previews
  • Fix delete
  • Fix check name methods in rename action
  • Fix scroll after creating a resource
  • Hide columns on smaller resolutions (and check when the sidebar is opened)
  • Check dropzone
  • Fix authentication on public links
  • Shared with link icon in the shared with column
  • Check indicators actions
  • Add not found messages
  • Public link requires authorisation after navigating into a folder
  • Extra slash when navigating into nested folders
  • Check quota
  • Fix mobile resolution
  • Display info in the footer
  • Fix trashbin actions
  • Bring back visually hidden page titles
  • Default action
  • Move file drop to views
  • Check dropzone position

Upload files

  • Do not reload list after the upload has been finished
  • Load preview after upload

Open tasks in ODS

  • Adjust selection model in ODS
  • Add footer for the table
  • Push and review disabled and isSelected props
  • Fix word wrapping for small widths in oc-table-files
  • Release ODS

Ideas for separate PRs

  • Move resource icon to ODS (create custom component)
  • Separate dependencies into prod and dev
  • Extend oc-breadcrumb component to separate the current route into items
  • Pass the original location into the query in location picker
  • Do not reload the files table when entering the location picker
  • Better position of the dropzone
  • Wrap table into own component and reuse in views (load resources in views and pass them via prop)
  • File actions for accepting/declining incoming shares
  • Enable favourite action on shared with views

Related issues

@LukasHirt LukasHirt self-assigned this Jan 19, 2021
@update-docs
Copy link

update-docs bot commented Jan 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
@LukasHirt LukasHirt mentioned this pull request Feb 16, 2021
Closed
6 tasks
@LukasHirt LukasHirt changed the title Add AllFiles view Bring oc-table-files component and refactor views Feb 18, 2021
@LukasHirt LukasHirt mentioned this pull request Feb 22, 2021
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13329/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13329/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13338/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13339/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13339/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13340/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13340/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13401/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13401/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13404/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13404/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13411/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13411/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13421/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13421/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13424/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13424/

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13816/

20210325-113449-761.png
20210325-113534-426.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13816/

20210325-113245-776.png
20210325-113320-042.png
20210325-113630-796.png
20210325-113700-758.png
20210325-113730-102.png
20210325-113759-764.png
20210325-114129-336.png
20210325-114202-346.png
20210325-114236-034.png
20210325-114309-121.png
20210325-114453-924.png
20210325-114530-680.png
20210325-114633-266.png
20210325-114706-223.png
20210325-114819-045.png
20210325-114903-541.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13819/

20210325-114801-891.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13816/

20210325-114654-280.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/13831/

20210325-124541-900.png

@pascalwengerter pascalwengerter mentioned this pull request Mar 25, 2021
Merged
20 tasks
@LukasHirt LukasHirt marked this pull request as ready for review March 25, 2021 15:27
@LukasHirt LukasHirt requested a review from kulmann March 25, 2021 15:27
@kulmann kulmann merged commit ff31a81 into master Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the use-oc-table branch March 25, 2021 15:31
@refs
Copy link
Member

refs commented Mar 25, 2021

👏

@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
@individual-it individual-it mentioned this pull request Apr 1, 2021
Merged
@dschmidt dschmidt mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
10 participants
@LukasHirt @ownclouders @JammingBen @kulmann @refs @jasson99 @kiranparajuli589 @saw-jan @SwikritiT @Talank