-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added upload pending prompt on close/reload #4840
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm locally, I'll do a quick research and see if we can add a test to our suite :)
@anaswaratrajan could you add a changelog item to this PR inside the changelog/unreleased folder? Name of the file should follow the schema of enhancement-your-change
(since it's neither a bugfix nor a breaking change), and for the content of the file you can take inspiration from the existing changelog items!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@kulmann there seems to be a way to test this behaviour (see SeleniumHQ/selenium#8638), but not sure if we want to have tests for this and if so on which level to add them.. |
@pascalwengerter @kulmann Should I look into adding a unit test using jest? |
That would be lovely, yeah! Not sure how to handle long-running uploads in there, but perhaps setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🚀
Description
Added an unload event listener that prompts user if there are pending uploads while user closes/ reloads/ navigates to another URL.
Related Issue
Motivation and Context
The pending uploads are cancelled on closing/reloading window. A prompt is required to warn users of upload cancellation.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: