Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt breadcrumbs baseUrl according to recent route changes #4975

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 16, 2021

Description

A recent PR changed the route for the "all files" view from personal to all. Breadcrumbs baseUrl was missed in that PR.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Apr 16, 2021
@kulmann kulmann self-assigned this Apr 16, 2021
@update-docs
Copy link

update-docs bot commented Apr 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14710/

20210416-080012-737.png

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, seems like I missed this one - thanks for taking care!

@kulmann kulmann merged commit 6389d60 into master Apr 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-breadcrumbs-routing branch April 16, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants