Move location picker hint under breadcrumbs #5008
Conversation
| @@ -158,7 +154,7 @@ export default { | |||
| }, | |||
|
|
|||
| sidebarNavItems() { | |||
| if (this.publicPage()) { | |||
| if (!this.user.token) { | |||
There was a problem hiding this comment.
What was the motivation behind this change here?
There was a problem hiding this comment.
publicPage is true for a page that can be used in both authorised/unauthorised context (location picker, media viewer, etc.). So if the user would be in location picker with his own private resources he wouldn't see the navigation because it is a public page.
| @@ -26,14 +26,10 @@ | |||
| :logo-img="logoImage" | |||
| :product-name="productName" | |||
| :nav-items="sidebarNavItems" | |||
| :hide-nav="sidebar.navigationHidden" | |||
There was a problem hiding this comment.
Are we removing the general capability of hidding the sidebar? 🤔
There was a problem hiding this comment.
The whole sidebar can be still hidden with isSidebarVisible. This is only about the navigation items. And from my understanding the sidebar should behave now only as navigation so I do not see much point in giving the option to hide it 🤷
I guess that happens only in the location picker? I'll dig into it |
Description
We've moved the hint that is describing how to use the Location picker from sidebar under the breadcrumbs. There is navigation of the Files extension displayed in the sidebar now instead.
Screenshots (if appropriate):
Types of changes