Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27042021 quick action id to class #5028

Merged
merged 1 commit into from
Apr 27, 2021
Merged

27042021 quick action id to class #5028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-quick-action-ids
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Change quick action from IDs to classes

Quick action button IDs were repeated in every row of the file table, which isn't allowed in HTML (IDs must be unique per document).
By changing to classes, this offense was resolved.

https://github.com/owncloud/web/pull/5028
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/FilesLists/QuickActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<div class="uk-flex">
<oc-button
v-for="action in filteredActions"
:id="`files-quick-action-${action.id}`"
:key="action.label"
:aria-label="action.label"
:uk-tooltip="action.label"
appearance="raw"
class="oc-mr-xs"
:class="`files-quick-action-${action.id}`"
@click.stop="action.handler({ item, client: $client, store: $store })"
>
<oc-icon :name="action.icon" class="uk-flex" />
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/pageObjects/FilesPageElement/filesRow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module.exports = {
locateStrategy: 'xpath'
},
quickAction: {
selector: '//button[@id="files-quick-action-%s"]',
selector: '//button[@class="files-quick-action-%s"]',
locateStrategy: 'xpath'
}
}
Expand Down