Fix z-index on the new file menu #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
approved these changes
Apr 30, 2021
AlexAndBear
approved these changes
Apr 30, 2021
pascalwengerter
requested changes
Apr 30, 2021
|
But it's not related to our a11y swarming, is it? 🤷 |
Uh true yeah, I'll restart Drone 🤦🏽 sorry! |
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15243/
|
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15243/
|
|
Ahhh now other modals are hidden, need to work on that again. Edit: Updated with a proper solution. |
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15247/
|
kulmann
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the z-index on the files-app-bar because it prevented the new file menu from having a higher z-index than the table headers. As a result the new file menu was being overlapped by them.
Types of changes
Checklist: