-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: do not reset file selection in batch actions #5107
Fix: do not reset file selection in batch actions #5107
Conversation
This comment has been minimized.
This comment has been minimized.
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUINotifications-displayNotificationsOnWebUI-feature-18.png |
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUITrashbinDelete-trashbinDelete-feature-113.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinDelete-trashbinDelete-feature-42.png |
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIMarkdownEditor-markdownFile-feature-62.pngwebUIMarkdownEditor-markdownFile-feature-63.png |
💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalUsersExpire-shareWithUsersExpiringShares-feature-240.png |
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-38.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-82.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-97.png |
💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalUsersExpireToRoot-shareWithUsersExpiringShares-feature-232.png |
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-106.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-11.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-147.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-24.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-86.png |
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png |
💥 Acceptance tests Upload failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIUpload-upload-feature-130.pngwebUIUpload-upload-feature-151.pngwebUIUpload-upload-feature-89.pngwebUIUpload-upload-feature-98.pngwebUIUpload-uploadEdgecases-feature-109.png |
💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-109.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-26.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-79.png |
💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUITrashbinRestore-trashbinRestore-feature-138.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUITrashbinRestore-trashbinRestore-feature-181.pngwebUITrashbinRestore-trashbinRestore-feature-222.pngwebUITrashbinRestore-trashbinRestore-feature-241.pngwebUITrashbinRestore-trashbinRestore-feature-260.pngwebUITrashbinRestore-trashbinRestore-feature-30.png |
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingPublicManagement-publicLinkIndicator-feature-110.pngwebUISharingPublicManagement-shareByPublicLink-feature-102.pngwebUISharingPublicManagement-shareByPublicLink-feature-12.pngwebUISharingPublicManagement-shareByPublicLink-feature-201.pngwebUISharingPublicManagement-shareByPublicLink-feature-64.pngwebUISharingPublicManagement-shareByPublicLink-feature-90.png |
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalGroups-shareWithGroups-feature-100.pngwebUISharingInternalGroups-shareWithGroups-feature-260.pngwebUISharingInternalGroups-shareWithGroups-feature-72.pngwebUISharingInternalGroups-shareWithGroups-feature-73.pngwebUISharingInternalGroups-shareWithGroups-feature-74.png |
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIFilesList-fileList-feature-46.pngwebUIFilesList-sort-feature-51.pngwebUIFilesList-sort-feature-72.pngwebUIFilesSearch-search-feature-122.pngwebUIFilesSearch-search-feature-175.png |
💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalUsersToRoot-shareWithUsers-feature-103.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-275.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-57.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-74.png |
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIFavorites-favoritesFile-feature-110.pngwebUIFavorites-favoritesFile-feature-131.pngwebUIFavorites-favoritesFile-feature-14.pngwebUIFavorites-favoritesFile-feature-30.pngwebUIFavorites-favoritesFile-feature-85.pngwebUIFavorites-unfavoriteFile-feature-104.pngwebUIFavorites-unfavoriteFile-feature-13.pngwebUIFavorites-unfavoriteFile-feature-34.pngwebUIFavorites-unfavoriteFile-feature-55.pngwebUIFavorites-unfavoriteFile-feature-72.png |
💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingNotifications-shareWithGroups-feature-24.pngwebUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithGroups-feature-24.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalGroupsToRoot-shareWithGroups-feature-128.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-234.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-69.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-70.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-71.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-74.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-95.png |
💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIDeleteFilesFolders-deleteFilesFolders-feature-111.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-12.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-122.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-159.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-180.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-235.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-249.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-295.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-308.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-53.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-54.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-55.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-56.png |
💥 Acceptance tests IntegrationApp2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIMoveFilesFolders-moveFiles-feature-20.pngwebUIMoveFilesFolders-moveFolders-feature-20.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUIUpload-upload-feature-89.png |
💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIDeleteFilesFolders-deleteFilesFolders-feature-12.pngwebUIFavorites-favoritesFile-feature-14.pngwebUIFavorites-unfavoriteFile-feature-13.pngwebUIFavorites-unfavoriteFile-feature-55.pngwebUIFilesCopy-copy-feature-10.pngwebUIRenameFiles-renameFiles-feature-22.pngwebUIRenameFiles-renameFiles-feature-23.pngwebUIRenameFiles-renameFiles-feature-24.pngwebUIRenameFiles-renameFiles-feature-25.pngwebUIRenameFiles-renameFiles-feature-26.pngwebUIRenameFiles-renameFiles-feature-43.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-50.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-72.png |
💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIFiles-download-feature-11.pngwebUIFiles-download-feature-24.pngwebUIFilesActionMenu-versions-feature-14.pngwebUIFilesCopy-copy-feature-10.pngwebUIFilesCopy-copy-feature-108.pngwebUIFilesCopy-copy-feature-116.pngwebUIFilesCopy-copy-feature-127.pngwebUIFilesCopy-copy-feature-26.pngwebUIFilesCopy-copy-feature-68.pngwebUIFilesCopy-copy-feature-69.pngwebUIFilesCopy-copy-feature-70.pngwebUIFilesCopy-copy-feature-71.pngwebUIFilesCopy-copy-feature-74.pngwebUIFilesCopy-copy-feature-87.pngwebUIFilesCopy-copy-feature-98.png |
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUILogin-adminBlocksUser-feature-20.pngwebUIPreview-imageMediaViewer-feature-13.pngwebUIPreview-imageMediaViewer-feature-131.pngwebUIPreview-imageMediaViewer-feature-14.pngwebUIPreview-imageMediaViewer-feature-140.pngwebUIPreview-imageMediaViewer-feature-149.pngwebUIPreview-imageMediaViewer-feature-15.pngwebUIPreview-imageMediaViewer-feature-158.pngwebUIPreview-imageMediaViewer-feature-17.pngwebUIPreview-imageMediaViewer-feature-24.pngwebUIPreview-imageMediaViewer-feature-34.pngwebUIPreview-imageMediaViewer-feature-55.pngwebUIPreview-imageMediaViewer-feature-56.pngwebUIPreview-imageMediaViewer-feature-59.pngwebUIPreview-imageMediaViewer-feature-67.pngwebUIPreview-imageMediaViewer-feature-83.pngwebUIPreview-imageMediaViewer-feature-90.png |
💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingInternalUsers-shareWithUsers-feature-112.pngwebUISharingInternalUsers-shareWithUsers-feature-341.pngwebUISharingInternalUsers-shareWithUsers-feature-82.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-199.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-31.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-92.png |
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIMoveFilesFolders-moveFiles-feature-105.pngwebUIMoveFilesFolders-moveFiles-feature-12.pngwebUIMoveFilesFolders-moveFiles-feature-140.pngwebUIMoveFilesFolders-moveFiles-feature-20.pngwebUIMoveFilesFolders-moveFiles-feature-43.pngwebUIMoveFilesFolders-moveFiles-feature-79.pngwebUIMoveFilesFolders-moveFiles-feature-81.pngwebUIMoveFilesFolders-moveFiles-feature-82.pngwebUIMoveFilesFolders-moveFiles-feature-85.pngwebUIMoveFilesFolders-moveFiles-feature-97.pngwebUIMoveFilesFolders-moveFolders-feature-12.pngwebUIMoveFilesFolders-moveFolders-feature-20.pngwebUIMoveFilesFolders-moveFolders-feature-33.pngwebUIMoveFilesFolders-moveFolders-feature-66.pngwebUIMoveFilesFolders-moveFolders-feature-68.pngwebUIMoveFilesFolders-moveFolders-feature-69.pngwebUIMoveFilesFolders-moveFolders-feature-72.pngwebUIMoveFilesFolders-moveFolders-feature-81.pngwebUIMoveFilesFolders-moveFolders-feature-88.png |
💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingPublicBasic-publicLinkCreate-feature-102.pngwebUISharingPublicBasic-publicLinkCreate-feature-120.pngwebUISharingPublicBasic-publicLinkCreate-feature-138.pngwebUISharingPublicBasic-publicLinkCreate-feature-177.pngwebUISharingPublicBasic-publicLinkEdit-feature-102.pngwebUISharingPublicBasic-publicLinkEdit-feature-116.pngwebUISharingPublicBasic-publicLinkEdit-feature-131.pngwebUISharingPublicBasic-publicLinkEdit-feature-146.pngwebUISharingPublicBasic-publicLinkEdit-feature-161.pngwebUISharingPublicBasic-publicLinkEdit-feature-181.pngwebUISharingPublicBasic-publicLinkEdit-feature-204.pngwebUISharingPublicBasic-publicLinkEdit-feature-30.pngwebUISharingPublicBasic-publicLinkEdit-feature-31.pngwebUISharingPublicBasic-publicLinkEdit-feature-32.pngwebUISharingPublicBasic-publicLinkEdit-feature-33.pngwebUISharingPublicBasic-publicLinkEdit-feature-56.pngwebUISharingPublicBasic-publicLinkEdit-feature-57.pngwebUISharingPublicBasic-publicLinkEdit-feature-58.pngwebUISharingPublicBasic-publicLinkEdit-feature-59.pngwebUISharingPublicBasic-publicLinkEdit-feature-82.pngwebUISharingPublicBasic-publicLinkEdit-feature-83.pngwebUISharingPublicBasic-publicLinkEdit-feature-84.pngwebUISharingPublicBasic-publicLinkEdit-feature-85.pngwebUISharingPublicBasic-publicLinkEdit-feature-88.png |
💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUISharingAcceptShares-acceptShares-feature-100.pngwebUISharingAcceptShares-acceptShares-feature-116.pngwebUISharingAcceptShares-acceptShares-feature-135.pngwebUISharingAcceptShares-acceptShares-feature-16.pngwebUISharingAcceptShares-acceptShares-feature-203.pngwebUISharingAcceptShares-acceptShares-feature-218.pngwebUISharingAcceptShares-acceptShares-feature-235.pngwebUISharingAcceptShares-acceptShares-feature-78.pngwebUISharingAcceptShares-acceptShares-feature-89.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-110.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-131.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-143.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-15.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-158.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-235.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-245.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-255.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-267.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-282.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-299.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-31.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-315.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-357.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-366.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-379.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-397.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-50.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-72.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-90.png |
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15457/
webUIRenameFiles-renameFiles-feature-117.pngwebUIRenameFiles-renameFiles-feature-118.pngwebUIRenameFiles-renameFiles-feature-119.pngwebUIRenameFiles-renameFiles-feature-138.pngwebUIRenameFiles-renameFiles-feature-139.pngwebUIRenameFiles-renameFiles-feature-143.pngwebUIRenameFiles-renameFiles-feature-151.pngwebUIRenameFiles-renameFiles-feature-157.pngwebUIRenameFiles-renameFiles-feature-163.pngwebUIRenameFiles-renameFiles-feature-169.pngwebUIRenameFiles-renameFiles-feature-176.pngwebUIRenameFiles-renameFiles-feature-186.pngwebUIRenameFiles-renameFiles-feature-202.pngwebUIRenameFiles-renameFiles-feature-22.pngwebUIRenameFiles-renameFiles-feature-227.pngwebUIRenameFiles-renameFiles-feature-23.pngwebUIRenameFiles-renameFiles-feature-24.pngwebUIRenameFiles-renameFiles-feature-249.pngwebUIRenameFiles-renameFiles-feature-25.pngwebUIRenameFiles-renameFiles-feature-26.pngwebUIRenameFiles-renameFiles-feature-260.pngwebUIRenameFiles-renameFiles-feature-38.pngwebUIRenameFiles-renameFiles-feature-39.pngwebUIRenameFiles-renameFiles-feature-40.pngwebUIRenameFiles-renameFiles-feature-43.pngwebUIRenameFiles-renameFiles-feature-62.pngwebUIRenameFiles-renameFiles-feature-77.pngwebUIRenameFiles-renameFiles-feature-90.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-21.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-22.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-36.pngwebUIRenameFolders-renameFolders-feature-107.pngwebUIRenameFolders-renameFolders-feature-108.pngwebUIRenameFolders-renameFolders-feature-109.pngwebUIRenameFolders-renameFolders-feature-122.pngwebUIRenameFolders-renameFolders-feature-127.pngwebUIRenameFolders-renameFolders-feature-132.pngwebUIRenameFolders-renameFolders-feature-138.pngwebUIRenameFolders-renameFolders-feature-147.pngwebUIRenameFolders-renameFolders-feature-22.pngwebUIRenameFolders-renameFolders-feature-23.pngwebUIRenameFolders-renameFolders-feature-24.pngwebUIRenameFolders-renameFolders-feature-25.pngwebUIRenameFolders-renameFolders-feature-26.pngwebUIRenameFolders-renameFolders-feature-38.pngwebUIRenameFolders-renameFolders-feature-39.pngwebUIRenameFolders-renameFolders-feature-40.pngwebUIRenameFolders-renameFolders-feature-43.pngwebUIRenameFolders-renameFolders-feature-58.pngwebUIRenameFolders-renameFolders-feature-67.pngwebUIRenameFolders-renameFolders-feature-79.png |
@kulmann PR is basically ready for the delete modal but needs a decision if the same should happen also when cancelling location picker since that is a completely custom route... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a changelog, then it's good to go.
As discussed we won't restore the selection for now when cancelling from within the location picker (i.e. cancelling copy/move).
1655b87
to
23c3823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.