Action toasts #5147
Merged
Action toasts #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUINotifications-displayNotificationsOnWebUI-feature-18.png |
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUITrashbinDelete-trashbinDelete-feature-113.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinDelete-trashbinDelete-feature-42.png |
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUIMarkdownEditor-markdownFile-feature-62.pngwebUIMarkdownEditor-markdownFile-feature-63.png |
💥 Visual regression tests webUIOCISFiles3 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
Diff Image: |
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-38.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-82.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-97.png |
💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUISharingInternalUsersExpireToRoot-shareWithUsersExpiringShares-feature-232.png |
💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUISharingInternalUsersExpire-shareWithUsersExpiringShares-feature-240.png |
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-106.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-11.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-147.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-24.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-86.png |
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png |
💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Acceptance tests Upload failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15655/
webUIUpload-upload-feature-130.pngwebUIUpload-upload-feature-151.pngwebUIUpload-upload-feature-89.pngwebUIUpload-upload-feature-98.pngwebUIUpload-uploadEdgecases-feature-109.png |
10 tasks
|
Also fixes #3588 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces confirmation toasts for copying (private/public) links to the clipboard. Refactored into a
CopyToClipboardButtoncomponent. We can decide later on if we want to move it to ODS (would need to extract the confirmation message then, as that needs to stay in web, and replace it with just emitting an event).Motivation and Context
a11y improvements
How Has This Been Tested?
Types of changes
Checklist: