Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Adjust steps that try to navigate private links #5174

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented May 31, 2021

Description

This PR adjusts the test step that tries to navigate private link, meaning that the navigation process is supposed to be unsuccessful.

The changes made by this PR and how they work

  • When a user tries to navigate a private link which they don't have permission to , they shouldn't be able to do so and should be redirected to the login page. When a user with permission accesses the private link then #webContainer should be visible to them and they shouldn't be logged out . But for user trying to access it without permission #webContainer shloudn't be present and they should be redirected to login page. This PR adds that extra check

Related Issue

Motivation and Context

These changes were necessary because previously in steps dealing with tries to we used to check the errors in then and in when step we used to check the behavior of the webUI while trying to do certain operation like navigating private link in this case but we didn't check everything.
Now we want our when step to perform all the task that we perform while actually navigating private link and we want to make sure that the process is unsuccessful at when step, so that we know the cause if that step fails for some reason or starts behaving in undesired manner.

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@individual-it individual-it merged commit 62ea1e6 into master Jun 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the refactor-tries-to-privatelink branch June 1, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants