[tests-only] Adjust steps that try to navigate private links #5174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the test step that tries to navigate private link, meaning that the navigation process is supposed to be unsuccessful.
The changes made by this PR and how they work
tries to
navigate a private link which they don't have permission to , they shouldn't be able to do so and should be redirected to the login page. When a user with permission accesses the private link then#webContainer
should be visible to them and they shouldn't be logged out . But for user trying to access it without permission#webContainer
shloudn't be present and they should be redirected to login page. This PR adds that extra checkRelated Issue
Motivation and Context
These changes were necessary because previously in steps dealing with
tries to
we used to check the errors inthen
and inwhen
step we used to check the behavior of the webUI while trying to do certain operation likenavigating private link
in this case but we didn't check everything.Now we want our
when
step to perform all the task that we perform while actuallynavigating private link
and we want to make sure that the process is unsuccessful at when step, so that we know the cause if that step fails for some reason or starts behaving in undesired manner.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: