unit tests for packages/web-app-files/src/mixins.js:fileTypeIcon #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested review from
phil-davis,
LukasHirt,
kulmann,
kiranparajuli589 and
saw-jan
|
Kudos, SonarCloud Quality Gate passed! |
LukasHirt
approved these changes
Jun 15, 2021
delete-merged-branch
bot
deleted the
unitTests_web-app-files_src_mixins_fileTypeIcon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unit tests for
fileTypeIconfunction and a small fix for the case if the extension is not a stringRelated Issue
part of #5236
How Has This Been Tested?
yarn test:unitTypes of changes
Checklist:
Open tasks: