Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete batch action in read only shares #5441

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Fix delete batch action in read only shares #5441

merged 2 commits into from
Jul 2, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 2, 2021

Description

This PR fixes that we showed the batch action for deleting files/folders for read only shares. Additionally we return early in the batch action availability checks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jul 2, 2021
@kulmann kulmann force-pushed the batch-action-streamlining branch from 484c2d2 to cf033b1 Compare July 2, 2021 15:00
pascalwengerter
pascalwengerter approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕵🏽

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17035/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/17035/7/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders-feature-131.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-131.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-249.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-249.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-272.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-272.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17042/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@kulmann kulmann merged commit 5f8ed00 into master Jul 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the batch-action-streamlining branch July 2, 2021 21:53
@micbar micbar mentioned this pull request Jul 13, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @ownclouders @pascalwengerter