Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] fix: load folder in media viewer #5585

Merged
merged 2 commits into from
Aug 4, 2021
Merged

[full-ci] fix: load folder in media viewer #5585

merged 2 commits into from
Aug 4, 2021

Conversation

LukasHirt
Copy link
Collaborator

@ownclouders

This comment has been minimized.

Sign in to view
pascalwengerter
pascalwengerter reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did some manual testing and while it works great most of the time, sometimes images don't load properly (esp. when circling through them via the < and > icons). Investigating now if that was the case before already

@fschade fschade changed the title fix: load folder in media viewer [full-ci] fix: load folder in media viewer Jul 29, 2021
@ownclouders

This comment has been minimized.

Sign in to view
@ownclouders

This comment has been minimized.

Sign in to view
@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Aug 2, 2021 •
edited
Loading

sometimes images don't load properly (esp. when circling through them via the < and > icons)

What exactly breaks? Requested image is not loading? Other images are not loaded and you cannot navigate? I tried both this PR and master and works fine for me (oc10) 🤷

fschade
fschade approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Aug 4, 2021 •
edited
Loading

sometimes images don't load properly (esp. when circling through them via the < and > icons)

What exactly breaks? Requested image is not loading? Other images are not loaded and you cannot navigate? I tried both this PR and master and works fine for me (oc10) 🤷

@LukasHirt sorry mate, I quickly checked whilst doing smoke testing, perhaps it had been a caching issue on my side or sth. With the latest fixes today it seems really good 👌🏽 👏🏽

@ownclouders

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit bccc54a into master Aug 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/reload-media-viewer branch August 4, 2021 11:27
@kulmann
Copy link
Member

kulmann commented Aug 4, 2021

Force merged with randomly failing CI with same issue as on master. Not related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@fschade fschade fschade approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[media-viewer] Reloading does not work
5 participants
@LukasHirt @ownclouders @pascalwengerter @kulmann @fschade