Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Integration of drag & drop move for personal files #5588

Merged
merged 35 commits into from
Aug 19, 2021
Merged

[full-ci] Integration of drag & drop move for personal files #5588

merged 35 commits into from
Aug 19, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jul 29, 2021 •
edited
Loading

Description

See #5592

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 29, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/17797/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat
Copy link
Contributor Author

lookacat commented Aug 2, 2021

added a unittest, but the function itself will be refactored anyways so I think it makes more sence to do it there or we may write tests that will be thrown away.

@lookacat lookacat requested a review from LukasHirt August 2, 2021 11:07
@lookacat lookacat changed the title WIP: Integration of drag & drop move for personal files Integration of drag & drop move for personal files Aug 2, 2021
@lookacat lookacat requested a review from kulmann August 2, 2021 11:08
@ownclouders
Copy link
Contributor

Results for oCISResharing1 https://drone.owncloud.com/owncloud/web/17899/59/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPermissions1 https://drone.owncloud.com/owncloud/web/17900/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPermissions1 https://drone.owncloud.com/owncloud/web/17904/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat lookacat force-pushed the WEB-154-move-file-drag-drop branch from cf66e3e to 772d926 Compare August 3, 2021 07:52
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/17927/24/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/17928/39/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat
Copy link
Contributor Author

lookacat commented Aug 3, 2021 •
edited
Loading

plz dont kill my CI 😿

@kulmann
Copy link
Member

kulmann commented Aug 3, 2021

plz dont kill my CI 😿

Builds get killed on scenario failure to save resources. If you need a full CI run, you can add [full-ci] as prefix to your PR title. On the next push CI will run all scenarios, regardless of failures.

@lookacat lookacat changed the title Integration of drag & drop move for personal files [full-ci] Integration of drag & drop move for personal files Aug 3, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingPublicBasic https://drone.owncloud.com/owncloud/web/17933/33/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter mentioned this pull request Aug 3, 2021
Merged
9 tasks
@lookacat lookacat requested a review from fschade August 17, 2021 13:46
@lookacat lookacat requested a review from kulmann August 17, 2021 15:12
kulmann
kulmann requested changes Aug 17, 2021
View reviewed changes
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/views/Personal.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/views/Personal.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/Personal.vue Outdated Show resolved Hide resolved
@lookacat lookacat requested a review from kulmann August 18, 2021 08:43
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/18395/11/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:109

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/18395/25/1
The following scenarios passed on retry:

  • webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

@kulmann kulmann force-pushed the WEB-154-move-file-drag-drop branch from 0cc8af1 to 3ac9287 Compare August 18, 2021 15:24
kulmann
kulmann approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to see row highlighting for the drop target. But that can happen in another PR.

@kulmann
Copy link
Member

kulmann commented Aug 18, 2021

Merging only with squashing please.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18413/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@kulmann
Copy link
Member

kulmann commented Aug 19, 2021

Added another commit to fix sonarcloud code smells. Still good for merge IMO ;-)

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.6% 60.6% Coverage
0.0% 0.0% Duplication

@kulmann kulmann mentioned this pull request Aug 19, 2021
Closed
21 tasks
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18424/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@lookacat lookacat dismissed pascalwengerter’s stale review August 19, 2021 07:30

it should be good to go

@lookacat lookacat merged commit bbb39a4 into master Aug 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the WEB-154-move-file-drag-drop branch August 19, 2021 07:30
@kiranparajuli589 kiranparajuli589 mentioned this pull request Dec 9, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter left review comments

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lookacat @ownclouders @kulmann @pascalwengerter @fschade