-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Integration of drag & drop move for personal files #5588
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oCISBasic https://drone.owncloud.com/owncloud/web/17797/46/1 |
added a unittest, but the function itself will be refactored anyways so I think it makes more sence to do it there or we may write tests that will be thrown away. |
Results for oCISResharing1 https://drone.owncloud.com/owncloud/web/17899/59/1 |
Results for oCISSharingPermissions1 https://drone.owncloud.com/owncloud/web/17900/56/1 |
Results for oCISSharingPermissions1 https://drone.owncloud.com/owncloud/web/17904/56/1 |
cf66e3e
to
772d926
Compare
Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/17927/24/1 |
Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/17928/39/1 |
plz dont kill my CI 😿 |
Builds get killed on scenario failure to save resources. If you need a full CI run, you can add |
Results for oC10SharingPublicBasic https://drone.owncloud.com/owncloud/web/17933/33/1 |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/18395/11/1
|
Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/18395/25/1
|
0cc8af1
to
3ac9287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd like to see row highlighting for the drop target. But that can happen in another PR.
Merging only with squashing please. |
Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18413/40/1
|
Added another commit to fix sonarcloud code smells. Still good for merge IMO ;-) |
SonarCloud Quality Gate failed. |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18424/12/1
|
Description
See #5592
Types of changes
Checklist: