Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signout icon #5681

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Change signout icon #5681

merged 1 commit into from
Aug 16, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 16, 2021

Description

Based on user feedback that @rpocklin received and forwarded to us, this PR changes the signout icon in the personal menu. Previous one was not clear enough. See screenshots for before and after comparison.

Issue

Fixes #5590

Motivation and Context

UX

How Has This Been Tested?

  • CI

Screenshots:

Before

Screenshot 2021-08-16 at 17 40 21

After

Screenshot 2021-08-16 at 17 39 41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18332/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit 76dc256 into master Aug 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the change-logout-icon branch August 16, 2021 18:13
@rpocklin
Copy link
Contributor

@kulmann Thanks for doing that, appreciate it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Icon - Logout menu
4 participants