Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests] added unit tests for LocationPicker view #5697

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[unit-tests] added unit tests for LocationPicker view #5697

merged 1 commit into from
Jan 28, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Aug 19, 2021 •
edited
Loading

Description

Added unit tests for LocationPicker view

Related Issue

How Has This Been Tested?

  • yarn test:unit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18419/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 19, 2021
Closed
11 tasks
@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18421/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18421/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@kiranparajuli589 kiranparajuli589 requested review from saw-jan and dpakach and removed request for kulmann, pascalwengerter and fschade August 19, 2021 06:50
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18421/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/18421/39/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:363

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 5 times, most recently from aa228cb to bdbe852 Compare August 20, 2021 03:11
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18468/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18468/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18468/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kiranparajuli589 kiranparajuli589 self-assigned this Aug 20, 2021
@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/18468/55/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18469/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/18469/55/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

@kiranparajuli589 could you rebase this one to current master please? :)

@kiranparajuli589
Copy link
Contributor Author

@kiranparajuli589 could you rebase this one to current master please? :)

There are some test cases that need fixes, I'll push the rebased code asap.

@kiranparajuli589 kiranparajuli589 requested review from pascalwengerter and removed request for LukasHirt November 9, 2021 08:56
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20145/15/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@individual-it
Copy link
Member

blocked waiting for review @kulmann @pascalwengerter

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/20691/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 2 times, most recently from 673e6b5 to c88b4f2 Compare December 8, 2021 04:13
@kiranparajuli589
Copy link
Contributor Author

ci failed at smoke tests OCIS https://drone.owncloud.com/owncloud/web/20723/10/18
restarted ♻️

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 2 times, most recently from 57991bc to 1efb694 Compare December 20, 2021 11:22
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21209/15/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21218/15/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 2 times, most recently from 7ec4fdb to bc3ec44 Compare December 27, 2021 05:13
@kiranparajuli589
Copy link
Contributor Author

ci is happy now. @pascalwengerter @kulmann waiting for the review

@kiranparajuli589 kiranparajuli589 force-pushed the unittest-views-location-picker branch 2 times, most recently from a2b0ccd to 683d873 Compare January 20, 2022 05:13
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22140/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@kulmann kulmann merged commit 2fe45ce into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the unittest-views-location-picker branch January 28, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@LukasHirt LukasHirt LukasHirt requested changes

@saw-jan saw-jan saw-jan left review comments

@kulmann kulmann kulmann approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kiranparajuli589 @ownclouders @pascalwengerter @individual-it @kulmann @dpakach @LukasHirt @saw-jan