Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable actions for the current folder in the right sidebar #5709

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 20, 2021

This PR disables certain actions entirely when the given resource is the current folder. This is a UX improvement for the right sidebar actions, when the sidebar has the current folder as it's context.

@update-docs
Copy link

update-docs bot commented Aug 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍 LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kulmann kulmann merged commit 98797c0 into release-4.1.0 Aug 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-current-folder-actions-sidebar branch August 20, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants