Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] fix(media-viewer): fix davProperties #5710

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Aug 20, 2021

mediaViewer still used davProperties from component scope, updated to
use shared DavProperties

@fschade fschade added the Type:Bug Something isn't working label Aug 20, 2021
@fschade fschade requested a review from kulmann August 20, 2021 09:10
@fschade fschade self-assigned this Aug 20, 2021
@update-docs
Copy link

update-docs bot commented Aug 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please also cherry-pick into the release branch for 4.1.0

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but needs a changelog item and I'd suggest targeting the release branch (and rebasing this PR to it and putting the changelog item into the respective folder:)

@kulmann
Copy link
Member

kulmann commented Aug 20, 2021

Code LGTM, but needs a changelog item and I'd suggest targeting the release branch (and rebasing this PR to it and putting the changelog item into the respective folder:)

If you target the release branch (which would be good), you can just add the PR link to the existing bugfix changelog item.

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18482/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/shareByPublicLink.feature:90

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18482/12/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter changed the base branch from master to release-4.1.0 August 20, 2021 10:08
@kulmann kulmann changed the title fix(media-viewer): fix davProperties [full-ci] fix(media-viewer): fix davProperties Aug 20, 2021
@kulmann kulmann force-pushed the fix-mediaviewer-dav-properties branch from f43d268 to 15c52c6 Compare August 20, 2021 11:52
@kulmann
Copy link
Member

kulmann commented Aug 20, 2021

Rebased to release branch and added PR link to existing changelog item

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18485/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18485/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

mediaViewer still used davProperties from component scope, updated to
use shared DavProperties
@fschade fschade force-pushed the fix-mediaviewer-dav-properties branch from 15c52c6 to d08f33a Compare August 20, 2021 13:06
@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 504ccd8 into release-4.1.0 Aug 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-mediaviewer-dav-properties branch August 20, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants