-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] fix(media-viewer): fix davProperties #5710
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Please also cherry-pick into the release branch for 4.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but needs a changelog item and I'd suggest targeting the release branch (and rebasing this PR to it and putting the changelog item into the respective folder:)
If you target the release branch (which would be good), you can just add the PR link to the existing bugfix changelog item. |
Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18482/34/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18482/12/1 |
f43d268
to
15c52c6
Compare
Rebased to release branch and added PR link to existing changelog item |
Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18485/28/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18485/12/1
|
mediaViewer still used davProperties from component scope, updated to use shared DavProperties
15c52c6
to
d08f33a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
mediaViewer still used davProperties from component scope, updated to
use shared DavProperties