-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit-tests] Added unit test todo skeleton for public link view #5749
Conversation
Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18691/46/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18691/12/1
|
9d9b8b9
to
ef5fc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
ef5fc0a
to
7ae3603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7ae3603
to
162bc70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you introduce a describe
for theming, which groups all checks that are about theming? That's the background image, logo image and the slogan in the footer. You have all of that, it's just about grouping that together as theming options.
Hint for the actual tests later on: there is quite some stuff described that can be tested through snapshot tests.
162bc70
to
bf6b402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Kudos, SonarCloud Quality Gate passed! |
Description
test.todo
skeleton forPublicLink
viewRelated Issue