Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests] Added unit test todo skeleton for public link view #5749

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[unit-tests] Added unit test todo skeleton for public link view #5749

merged 1 commit into from
Aug 31, 2021

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • Added unit tests test.todo skeleton for PublicLink view

Related Issue

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18691/46/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:14

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18691/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@delete-merged-branch delete-merged-branch bot deleted the branch master August 30, 2021 07:09
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review August 30, 2021 07:11
@kiranparajuli589 kiranparajuli589 self-assigned this Aug 30, 2021
@kiranparajuli589 kiranparajuli589 changed the base branch from refactor-favorites-spec to master August 30, 2021 07:42
@owncloud owncloud deleted a comment from update-docs bot Aug 30, 2021
saw-jan
saw-jan reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 30, 2021
Closed
11 tasks
saw-jan
saw-jan reviewed Aug 30, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kulmann
kulmann reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you introduce a describe for theming, which groups all checks that are about theming? That's the background image, logo image and the slogan in the footer. You have all of that, it's just about grouping that together as theming options.

Hint for the actual tests later on: there is quite some stuff described that can be tested through snapshot tests.

packages/web-app-files/tests/unit/views/PublicLink.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/views/PublicLink.spec.js Outdated Show resolved Hide resolved
kulmann
kulmann approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 merged commit 8f9791c into master Aug 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-public-link-view branch August 31, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@kulmann kulmann kulmann approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@individual-it individual-it Awaiting requested review from individual-it

@fschade fschade Awaiting requested review from fschade

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @ownclouders @kulmann @saw-jan