-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit-tests-only] Add todo unit tests for PrivateLink view #5750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please go ahead 🙌🏽
@pascalwengerter should I wait for this PR to be merged or add tests in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the top 4 todos into their own "when the page has loaded successfully" describe
block but otherwise good to go!
aa4e942
to
59543b8
Compare
59543b8
to
6ac26a3
Compare
it.todo('should have the background image set') | ||
it.todo('should display the page title') | ||
it.todo('should display the logo') | ||
it.todo('should call "getPathForFileId" method') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling with this description. I'd like to aim for a test driven
development approach in the future. For that we'd have to write unit tests as black box tests. A test description about whether or not a certain function was called would be not allowed in such a case. Instead you'd have to describe behaviour of the component (should resolve the provided file id to a path from the backend
).
6ac26a3
to
eba697b
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please go ahead!
Description
Added
todo
unit tests forPrivateLink
viewRelated Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: