Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests] Implemented todo unit tests for public link view #5756

Merged
merged 2 commits into from
Nov 30, 2021
Merged

[unit-tests] Implemented todo unit tests for public link view #5756

merged 2 commits into from
Nov 30, 2021

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • implemented todo unit tests for PublicLink view

Related Issue

How Has This Been Tested?

  • yarn test:unit

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 self-assigned this Aug 31, 2021
@kiranparajuli589 kiranparajuli589 mentioned this pull request Aug 31, 2021
Closed
11 tasks
@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18737/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@owncloud owncloud deleted a comment from update-docs bot Sep 2, 2021
saw-jan
saw-jan reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589 kiranparajuli589 force-pushed the test-public-link-implement-todo branch 2 times, most recently from b49c0bb to 8713cee Compare September 9, 2021 17:02
@kiranparajuli589 kiranparajuli589 requested review from pascalwengerter and removed request for pascalwengerter September 15, 2021 11:41
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19067/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19067/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kiranparajuli589 kiranparajuli589 force-pushed the test-public-link-implement-todo branch 2 times, most recently from b61b40b to f3966eb Compare November 8, 2021 10:27
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/20111/28/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingInd https://drone.owncloud.com/owncloud/web/20111/30/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISRename https://drone.owncloud.com/owncloud/web/20111/51/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10NotificationBasic https://drone.owncloud.com/owncloud/web/20111/39/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/20111/16/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingFilePermission https://drone.owncloud.com/owncloud/web/20111/21/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20114/14/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20114/15/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@individual-it
Copy link
Member

blocked waiting for review @kulmann @pascalwengerter

pascalwengerter
pascalwengerter approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and reviewed, good to go from my POV

pascalwengerter
pascalwengerter reviewed Nov 30, 2021
View reviewed changes
packages/web-app-files/tests/unit/views/PublicLink.spec.js
await wrapper.setData({ passwordRequired: true, password: 'some-pass' })

const submitButton = wrapper.find(selectors.submitButton)
await submitButton.trigger('submit')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranparajuli589 I was able to remove your workaround by switching from .trigger('click') which is correct from a users perspective to a .trigger('submit') which is the technically correct case since we're submitting a form 🤷🏽‍♂️ that was unexpected!

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingPubExpAndRoles https://drone.owncloud.com/owncloud/web/20548/39/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

@kulmann could be force-merged IMHO, fails because datepicker acceptance tests don't work but doesn't change functionality

@kulmann kulmann merged commit 0d22368 into master Nov 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-public-link-implement-todo branch November 30, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@saw-jan saw-jan saw-jan left review comments

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kiranparajuli589 @ownclouders @individual-it @pascalwengerter @dpakach @saw-jan @kulmann