-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit-tests] Implemented todo unit tests for public link view #5756
Conversation
Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18737/40/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7104bd
to
420a366
Compare
b49c0bb
to
8713cee
Compare
8713cee
to
bdf86cc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/19067/28/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19067/12/1
|
b61b40b
to
f3966eb
Compare
Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/20111/28/1 |
Results for oC10SharingInternalUsersSharingInd https://drone.owncloud.com/owncloud/web/20111/30/1 |
Results for oCISRename https://drone.owncloud.com/owncloud/web/20111/51/1 |
Results for oC10NotificationBasic https://drone.owncloud.com/owncloud/web/20111/39/1 |
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/20111/16/1 |
Results for oC10SharingFilePermission https://drone.owncloud.com/owncloud/web/20111/21/1 |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20114/14/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20114/15/1
|
blocked waiting for review @kulmann @pascalwengerter |
f3966eb
to
4f010aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and reviewed, good to go from my POV
await wrapper.setData({ passwordRequired: true, password: 'some-pass' }) | ||
|
||
const submitButton = wrapper.find(selectors.submitButton) | ||
await submitButton.trigger('submit') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiranparajuli589 I was able to remove your workaround by switching from .trigger('click')
which is correct from a users perspective to a .trigger('submit')
which is the technically correct case since we're submitting a form 🤷🏽♂️ that was unexpected!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Results for oC10SharingPubExpAndRoles https://drone.owncloud.com/owncloud/web/20548/39/1 |
@kulmann could be force-merged IMHO, fails because datepicker acceptance tests don't work but doesn't change functionality |
Description
PublicLink
viewRelated Issue
How Has This Been Tested?
yarn test:unit
Screenshots (if appropriate):
Types of changes
Checklist: