-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically show oC10 apps in app switcher menu #5996
Conversation
oh wow, thx @JammingBen! about the icon:
which one would you prefer @JammingBen @kulmann (I favour "Extension") |
I vote for Extension |
I also prefer the "extension"-icon over the "open in new window"-icon 👍 |
Also preferring the |
@kulmann yes, for sure. |
Yep, english as fallback is perfect. |
The extension icon is not yet available, is it? https://owncloud.design/#/Design%20Tokens/Icon That would need to be implemented in the ODS, I assume? |
Oh yes, true. You can add the .svg file to the design system in a PR and we'll release it quickly after. There is an ODS release in the pipeline for today or tomorrow anyway. |
👍 |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20144/14/1
|
@JammingBen @janackermann new (extension) icon is on current master with the new ODS release :) |
Great, thx! :) This is now ready for review, @kulmann maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried to get this to work (still would like @kulmann's opinion on the PHP parts 😅 ), seems like the extension
icon itself doesn't render in the web context (but does on https://owncloud.design/#/Design%20Tokens/Icon. I'll investigate and perhaps replace it in a bugfix ODS release later today to get this merged in the release!
Caught it, ODS bugfix release |
1330441
to
3215ef7
Compare
3215ef7
to
83ecc3d
Compare
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20243/14/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated changelog and docs. Code looks good. Also checked it in an app deployment and works like a charm. 😍
Kudos, SonarCloud Quality Gate passed! |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20250/15/1
|
With this change, oC10 apps will be listed in the app switcher menu.
2 things that are not so good with the current approach:
We only have full URLs to the icons. The config on the other hand expects a string to load the icons. Therefore the-> we use the extension iconapplication
icon is the default for now.The app name we get from-> That's okay for now.\OC::$server->getNavigationManager()->getAll()
is already translated. To overcome this, we currently load the app + 3 different l10n instances to provide proper solutions based on the original name... super ugly. Is there a way to use the already translated string for OC web?Related Issue
Screenshots:
Types of changes
Checklist: