Automatically show oC10 apps in app switcher menu

[JammingBen]

With this change, oC10 apps will be listed in the app switcher menu.

2 things that are not so good with the current approach:

• We only have full URLs to the icons. The config on the other hand expects a string to load the icons. Therefore the application icon is the default for now. -> we use the extension icon
• The app name we get from \OC::$server->getNavigationManager()->getAll() is already translated. To overcome this, we currently load the app + 3 different l10n instances to provide proper solutions based on the original name... super ugly. Is there a way to use the already translated string for OC web? -> That's okay for now.

Related Issue

• Fixes Show oC 10 Apps automatically in Web UI App Switcher  #5980

Screenshots:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[tbsbdr]

oh wow, thx @JammingBen!

about the icon:
our current "application" icon would be missleading as is symbolises settings.
I would suggest to have one of these icons in the app switcher for the time beeing:

• Message "Extension" https://fonts.google.com/icons?selected=Material%20Icons%3Aextension%3A
  

• Message "opens in new window"https://fonts.google.com/icons?selected=Material%20Icons%3Aextension%3A

which one would you prefer @JammingBen @kulmann (I favour "Extension")

[AlexAndBear]

I vote for Extension

[JammingBen]

I also prefer the "extension"-icon over the "open in new window"-icon 👍

[kulmann]

Also preferring the extension-icon.
While I agree that the solution to add the app display names for multiple languages feels a bit weird, I also don't see a better solution right now. Actually, web supports 6 languages (hardcoded) at the moment: de, fr, es, it, cs, gl. Could you please add the other ones as well? 😅

[AlexAndBear]

@kulmann yes, for sure.
What do you expect, if there is no translation for it, is the fallback to eng legit?

[kulmann]

@kulmann yes, for sure.
What do you expect, if there is no translation for it, is the fallback to eng legit?

Yep, english as fallback is perfect.

[JammingBen]

The extension icon is not yet available, is it? https://owncloud.design/#/Design%20Tokens/Icon That would need to be implemented in the ODS, I assume?

[kulmann]

The extension icon is not yet available, is it? https://owncloud.design/#/Design%20Tokens/Icon That would need to be implemented in the ODS, I assume?

Oh yes, true. You can add the .svg file to the design system in a PR and we'll release it quickly after. There is an ODS release in the pipeline for today or tomorrow anyway.

[AlexAndBear]

👍

[ownclouders]

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20144/14/1
The following scenarios passed on retry:

• webUISharingAcceptSharesToRoot/acceptShares.feature:108

[pascalwengerter]

@JammingBen @janackermann new (extension) icon is on current master with the new ODS release :)

[JammingBen]

Great, thx! :)

This is now ready for review, @kulmann maybe?

[pascalwengerter]

Just tried to get this to work (still would like @kulmann's opinion on the PHP parts 😅 ), seems like the extension icon itself doesn't render in the web context (but does on https://owncloud.design/#/Design%20Tokens/Icon. I'll investigate and perhaps replace it in a bugfix ODS release later today to get this merged in the release!

[pascalwengerter]

Just tried to get this to work (still would like @kulmann's opinion on the PHP parts sweat_smile ), seems like the extension icon itself doesn't render in the web context (but does on https://owncloud.design/#/Design%20Tokens/Icon. I'll investigate and perhaps replace it in a bugfix ODS release later today to get this merged in the release!

Caught it, ODS bugfix release incoming part of this PR

[ownclouders]

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20243/14/1
The following scenarios passed on retry:

• webUISharingAcceptSharesToRoot/acceptShares.feature:108

[kulmann]

I updated changelog and docs. Code looks good. Also checked it in an app deployment and works like a charm. 😍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[ownclouders]

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20250/15/1
The following scenarios passed on retry:

• webUIFilesActionMenu/versions.feature:15