-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unit-tests-only] Added unit tests for shared with others view #6175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranparajuli589
requested review from
fschade,
kulmann and
pascalwengerter
as code owners
December 20, 2021 12:17
kiranparajuli589
force-pushed
the
test-share-with-others
branch
2 times, most recently
from
December 21, 2021 10:57
7da3187
to
a871b04
Compare
pascalwengerter
previously requested changes
Dec 21, 2021
packages/web-app-files/tests/unit/views/SharedWithOthers.spec.js
Outdated
Show resolved
Hide resolved
kiranparajuli589
force-pushed
the
test-share-with-others
branch
from
December 22, 2021 05:36
a871b04
to
3703279
Compare
kiranparajuli589
force-pushed
the
test-share-with-others
branch
3 times, most recently
from
January 3, 2022 15:09
4ea40d7
to
aa0b90d
Compare
kiranparajuli589
force-pushed
the
test-share-with-others
branch
3 times, most recently
from
January 14, 2022 10:22
37d2175
to
bf6c8bf
Compare
phil-davis
force-pushed
the
test-share-with-others
branch
from
January 25, 2022 08:26
bf6c8bf
to
5b08e4f
Compare
This PR was already 78 commits behind master. I rebased to get fresh CI. |
kiranparajuli589
force-pushed
the
test-share-with-others
branch
2 times, most recently
from
January 26, 2022 06:49
bd72638
to
05d793f
Compare
@pascalwengerter I've stubbed every |
kiranparajuli589
force-pushed
the
test-share-with-others
branch
from
January 26, 2022 06:53
05d793f
to
1375055
Compare
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Jan 28, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SharedWithOthers
viewRelated Issue
How Has This Been Tested?
Types of changes
Checklist: