Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests-only] Added unit tests for shared with others view #6175

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[unit-tests-only] Added unit tests for shared with others view #6175

merged 1 commit into from
Jan 28, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • added unit tests for SharedWithOthers view

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 marked this pull request as draft December 21, 2021 03:12
@kiranparajuli589 kiranparajuli589 force-pushed the test-share-with-others branch 2 times, most recently from 7da3187 to a871b04 Compare December 21, 2021 10:57
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review December 21, 2021 10:57
@kiranparajuli589 kiranparajuli589 self-assigned this Dec 21, 2021
@kiranparajuli589 kiranparajuli589 force-pushed the test-share-with-others branch 3 times, most recently from 4ea40d7 to aa0b90d Compare January 3, 2022 15:09
@kiranparajuli589 kiranparajuli589 force-pushed the test-share-with-others branch 3 times, most recently from 37d2175 to bf6c8bf Compare January 14, 2022 10:22
@phil-davis phil-davis requested review from kulmann and removed request for saw-jan January 25, 2022 08:26
@phil-davis
Copy link
Contributor

This PR was already 78 commits behind master. I rebased to get fresh CI.
@pascalwengerter and/or @kulmann please review.

@kiranparajuli589 kiranparajuli589 force-pushed the test-share-with-others branch 2 times, most recently from bd72638 to 05d793f Compare January 26, 2022 06:49
@kiranparajuli589
Copy link
Contributor Author

@pascalwengerter I've stubbed every OC components used inside the ResourceTable components. The fixtures don't need to be updated after that. please review again!

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 170c8c7 into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the test-share-with-others branch January 28, 2022 08:38
@kiranparajuli589 kiranparajuli589 mentioned this pull request Feb 21, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @phil-davis @kulmann @pascalwengerter