Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version numbers #6190

Merged
merged 3 commits into from
Dec 24, 2021
Merged

Show version numbers #6190

merged 3 commits into from
Dec 24, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 23, 2021

Description

With this PR the web ui prints the package version and the backend version (if available) to the javascript console and sets them as meta generator tag in the html head. See screenshots below. There are some (known) situations where the backend version is not available. Those need to be fixed separately, this PR just makes use of the information. Only consequence is that the backend doesn't show up, so it's not an issue to fix it separately. The version of the web ui always gets shown, as it is included in the bundling process.

The product key in the version doesn't exist, yet, so for now it'll always fall back to ownCloud. I'll provide an oCIS PR so that oCIS will announce itself as product: "oCIS" in the future. For ownCloud 10 we don't need to change anything as the fallback is correct there.

Related Issue

Motivation and Context

Make debugging and bug reports easier.

How Has This Been Tested?

  • manually + with unit tests

Screenshots (if appropriate):

Screenshot 2021-12-23 at 14 16 58

Screenshot 2021-12-23 at 14 14 10

Screenshot 2021-12-23 at 14 16 32

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21373/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/21373/53/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:94

Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

changelog/unreleased/enhancement-print-version Outdated Show resolved Hide resolved
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to take a look at the code still, but yesterday was wondering if we should provide such information also to the user? Could live on the account page in the runtime for example, e.g. in a details/summary HTML tag so very subtle yet also available for less techy users?

@kulmann
Copy link
Member Author

kulmann commented Dec 24, 2021

Need to take a look at the code still, but yesterday was wondering if we should provide such information also to the user? Could live on the account page in the runtime for example, e.g. in a details/summary HTML tag so very subtle yet also available for less techy users?

We discussed this during the refinement and basically said that we'll have to show a lot of versions in the future. Since every extension that gets loaded from an external source comes with its own version number we'll eventually want to show all of them, which might need a dedicated "about" page in the future. But still, showing the web ui version and the backend version somewhere visible in the UI makes a lot of sense, even then. I'll create a ticket for it after christmas... thank you for bringing it up again! :-)

@pascalwengerter
Copy link
Contributor

@kulmann rebasing on current master should make the smoke tests way more stable :)

@kulmann
Copy link
Member Author

kulmann commented Dec 24, 2021

@kulmann rebasing on current master should make the smoke tests way more stable :)

Could you do that for me? Not at my desk

@pascalwengerter
Copy link
Contributor

@kulmann rebasing on current master should make the smoke tests way more stable :)

Could you do that for me? Not at my desk

Sure thing, just done it

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

51.4% 51.4% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/21389/64/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/21389/40/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:106

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/21389/37/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@pascalwengerter pascalwengerter merged commit 9a65237 into master Dec 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the show-version-numbers branch December 24, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show web ui version number to users
4 participants