Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Fixed some occurences of invalid $gettext usage #6834

Merged
merged 5 commits into from
May 3, 2022
Merged

[full-ci] Fixed some occurences of invalid $gettext usage #6834

merged 5 commits into from
May 3, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 28, 2022 •
edited
Loading

Fixes some invalid $gettext usages.

Todo

  • fix remaining 1 empty msgid in web-app-files
  • fix remaining 2 empty msgids in web-runtime

@update-docs
Copy link

update-docs bot commented Apr 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested a review from dschmidt April 28, 2022 22:57
dschmidt
dschmidt approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

packages/web-app-files/src/views/LocationPicker.vue Show resolved Hide resolved
@kulmann kulmann mentioned this pull request Apr 29, 2022
Closed
25 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Apr 29, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25154/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkEdit.feature:60

@dschmidt dschmidt changed the title Fixed some occurences of invalid $gettext usage [full-ci] Fixed some occurences of invalid $gettext usage Apr 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 75a1e4f into master May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-gettext-usage branch May 3, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @ownclouders @dschmidt @fschade