Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Search all files with ocis backend #6841

Merged
merged 1 commit into from
May 4, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 29, 2022

Description

Enhancement: Enable search all files for ocis backend

We've enabled the search all files feature for ocis backend:

  • Find files in sub directories
  • Find files in other places like project spaces

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 2, 2022

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/25251/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/25251/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-5-4-09-34-01.zip

@AlexAndBear AlexAndBear changed the title Load spaces in store Search all files in ocis May 2, 2022
@AlexAndBear AlexAndBear changed the title Search all files in ocis Search all files with ocis backend May 3, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review May 3, 2022 09:39
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor things from my side 👍

Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸 the ci still complains :(

@kulmann kulmann mentioned this pull request May 3, 2022
30 tasks
@AlexAndBear AlexAndBear changed the title Search all files with ocis backend [ful-ci] Search all files with ocis backend May 4, 2022
@AlexAndBear AlexAndBear changed the title [ful-ci] Search all files with ocis backend [full-ci] Search all files with ocis backend May 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

57.4% 57.4% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 1775056 into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the search-enhancements branch May 4, 2022 10:33
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants