-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] personal spaceId in URL #7053
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/26146/67/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the quota setting somewhere else, apart from that ok IMHO.
@@ -52,7 +55,7 @@ export class FolderLoaderLegacyPersonal implements FolderLoader { | |||
|
|||
// fetch user quota | |||
;(async () => { | |||
const user = await client.users.getUser(ref.user.id) | |||
const user = await client.users.getUser(router.currentRoute.params.storageId) | |||
store.commit('SET_QUOTA', user.quota) | |||
})() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong, afaict this would update the user specific quota when viewing someone else's personal space.
What happens, when we use a bookmark to enter oC Web and skipping the personal view? Does the quota get loaded at all (it's visible from the user menu)? This seems to the wrong place after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will create a followup issue to query quota from the backend in some other place (maybe quota component in the topbar, maybe something that polls with low frequency, let's see...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #7093 to follow up on this
buildWebDavFilesPath(this.user.id, resource), | ||
targetPath | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reduce the code duplication here? This block is almost exactly the same as for the move operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't spend time on it since the location picker will most likely go away. 😅
found an issue in upload-only public links, which were also the/one reason why CI failed. fixing it now... |
2bb5003
to
8944526
Compare
87b8130
to
1eb252b
Compare
Somehow we can't get a working ocis in the e2e tests... fails with:
|
SonarCloud Quality Gate failed. |
Description
We now include the personal space id in the URL instead of using a magic "home" alias. When using the old "home" alias the user gets redirected to the URL with their personal space id.
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: