Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Copy / move file name exists count duplicate #7119

Merged
merged 8 commits into from
Jun 14, 2022
Merged

Bugfix: Copy / move file name exists count duplicate #7119

merged 8 commits into from
Jun 14, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 13, 2022 •
edited
Loading

Description

See #7089

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review June 13, 2022 13:47
@lookacat lookacat changed the title Copy / move file name exists count duplicate Bugfix: Copy / move file name exists count duplicate Jun 13, 2022
@lookacat lookacat requested a review from kulmann June 13, 2022 14:21
@lookacat lookacat requested a review from kulmann June 14, 2022 08:21
@kulmann kulmann mentioned this pull request Jun 14, 2022
Closed
25 tasks
@lookacat lookacat requested a review from kulmann June 14, 2022 10:12
kulmann
kulmann approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.3% 85.3% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 3167dbd into master Jun 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the copy-move-name-conflict-iterate branch June 14, 2022 10:58
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugfix: Copy / move repeating action
2 participants
@lookacat @kulmann