Enable rename on shared resource #7390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
Aug 2, 2022
| @@ -384,7 +385,7 @@ export function buildSharedResource( | |||
| } | |||
| resource.canDownload = () => parseInt(share.state) === ShareStatus.accepted | |||
| resource.canShare = () => SharePermissions.share.enabled(share.permissions) | |||
| resource.canRename = () => SharePermissions.update.enabled(share.permissions) | |||
| resource.canRename = () => true | |||
There was a problem hiding this comment.
@kulmann I don't know if we can leave it this way, or we need a distinction between ocis and oc10
AlexAndBear
commented
Aug 2, 2022
Comment on lines
233
to
238
| if (file.isReceivedShare()) { | ||
| newPath = `${ | ||
| context.getters.spaces.find((space) => space.driveAlias === 'virtual/shares')?.webDavPath | ||
| }/` | ||
| } | ||
|
|
There was a problem hiding this comment.
@kulmann I think this needs a sharingJail or spaces check?
|
Problems:
|
|
Kudos, SonarCloud Quality Gate passed! |
|
Blocked by owncloud/ocis#4322 |
AlexAndBear
force-pushed
the
issues/6899#2
branch
from
2a2bc65
to
eb99f91
Compare
added 2 commits
October 6, 2022 15:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: