Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mediaSource and v-image-source #7935

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Nov 7, 2022

Description

This removes mediaSource and v-image-source.

Related Issue

  • Fixes <issue_link>

Motivation and Context

They are broken as they don't handle authentication anymore, thus I think we should not ship them in 6.0, when we want to get rid of them anyway ...

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dschmidt dschmidt force-pushed the remove-deprecated-mediasource branch from aefdf92 to f4a8952 Compare November 7, 2022 22:13
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit eba1fbd into stable-6.0 Nov 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-deprecated-mediasource branch November 8, 2022 08:50
@AlexAndBear AlexAndBear self-requested a review November 8, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants